Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: PublisherSync does not handle private queue #70

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Bug: PublisherSync does not handle private queue #70

merged 5 commits into from
Jul 25, 2024

Conversation

mackenzie-grimes-noaa
Copy link
Contributor

@mackenzie-grimes-noaa mackenzie-grimes-noaa commented Jul 24, 2024 •
edited
Loading

Linear Issue

IDSSE-817

Changes

Sorry for the numerous, very small Pull Requests.

  • Bug where PublisherSync did not replicate PublishConfirm functionality where "private" queues (name starting with _) receive a time-to-live of 10 seconds for each message

Explanation

For me, when New Data Service attempts to declare the _new_data queue, it would throw an error like this due to it not matching the existing queue on the RabbitMQ server:

PreconditionFailed: parameters for queue '_new_data' in vhost '/' not equivalent:
x-message-ttl is null but the current exchange is 10000

@mackenzie-grimes-noaa mackenzie-grimes-noaa changed the title Bug: PublisherSync does not handle private exchanges Bug: PublisherSync does not handle private queue Jul 24, 2024
Geary-Layne
Geary-Layne approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Geary-Layne Geary-Layne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mackenzie-grimes-noaa mackenzie-grimes-noaa merged commit e83485c into main Jul 25, 2024
2 checks passed
@mackenzie-grimes-noaa mackenzie-grimes-noaa deleted the bug/publisher-sync-private-exch branch July 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geary-Layne Geary-Layne Geary-Layne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mackenzie-grimes-noaa @Geary-Layne