Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup pytest coverage, remove build and dist folders #3

Merged
merged 2 commits into from
Jul 11, 2023
Merged

cleanup pytest coverage, remove build and dist folders #3

merged 2 commits into from
Jul 11, 2023

Conversation

mackenzie-grimes-noaa
Copy link
Contributor

@mackenzie-grimes-noaa mackenzie-grimes-noaa commented Jul 11, 2023 •
edited
Loading

  • pytest coverage GitHub action now only evaluates src files, not unit tests themselves
  • remove python/idsse_common/build and python/idsse_common/dist folders which are artifact of distribution and don't need to be checked in

GitHub Action pytest report is now bit more readable:

Name                                                                                                            Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------------------------------
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/__init__.py              0      0   100%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/aws_utils.py            77      5    94%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/config.py               74      9    88%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/json_message.py         22     22     0%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/log_util.py             38     38     0%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/path_builder.py        127     10    92%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/publish_confirm.py     141    141     0%
/home/runner/work/idss-engine-commons/idss-engine-commons/python/idsse_common/idsse/common/utils.py                78     33    58%
-----------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                             557    258    54%

rabellino-noaa
rabellino-noaa reviewed Jul 11, 2023
View reviewed changes
.github/workflows/run-tests.yml
pytest --cov=../idsse/common --cov-report=term
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think the relative pathing would work in Github Actions, nice to see it does you got the coverage to be more accurate!

rabellino-noaa
rabellino-noaa approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@rabellino-noaa rabellino-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cleaning things up, ship it!

@mackenzie-grimes-noaa mackenzie-grimes-noaa merged commit b61d57a into main Jul 11, 2023
4 checks passed
@mackenzie-grimes-noaa mackenzie-grimes-noaa deleted the chore/pytest-coverage-cleanup branch July 11, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabellino-noaa rabellino-noaa rabellino-noaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mackenzie-grimes-noaa @rabellino-noaa