Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFIP 2022 Hannah Update 2 #155

Open
wants to merge 10 commits into
base: HFIP2022
Choose a base branch
from

Conversation

hannahcbarnes
Copy link

@hannahcbarnes hannahcbarnes commented Sep 14, 2022

  • Enables GF to use AOD analysis instead of AOD from MERRA2 climatology
  • Fixes GF - radiation coupling
  • Fixes dry / moist mixing ratios in GF
  • Additional tuning to GF
  • Reverts previous change to sgscloud_radpre

The regression test log for gnu on hera are located in /scratch1/BMC/gsd-fv3-dev/hcbarnes/CommitTest/sorc/ufs_model.fd/tests

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@hannahcbarnes hannahcbarnes changed the title Hfip2022 hannah v2 HFIP 2022 Hannah Update 2 Sep 14, 2022
@hannahcbarnes
Copy link
Author

@haiqinli Can you look double check these modifications?

@haiqinli
Copy link
Collaborator

@hannahcbarnes The variable of aod_da should be added into cu_gf_driver.meta. The others look good. Thanks.

@hannahcbarnes
Copy link
Author

@haiqinli thanks. aod_da should now be a part of cu_gf_driver.meta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants