Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated submodules for Bug fixes to drag_suite.F90 and GFS_surface_composites.F90 #134

Conversation

mdtoyNOAA
Copy link
Collaborator

Description

This PR updates the .gitmodules submodule to point to ccpp/physics PR #140.
Is a change of answers expected from this PR? Yes.

Issue(s) addressed

None

Testing

How were these changes tested?
What compilers / HPCs was it tested with? Hera: Intel and GNU. Jet: Intel.
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? Yes.
  • Please commit the regression test log files in your ufs-weather-model branch

Baseline Reg test data on Hera at:
/scratch1/BMC/wrfruc/mtoy/stmp4/Michael.Toy/FV3_RT/REGRESSION_TEST_INTEL.2022_03_19
and
/scratch1/BMC/wrfruc/mtoy/stmp4/Michael.Toy/FV3_RT/REGRESSION_TEST_GNU.2022_03_19

Baseline Reg test data on Jet at:
/lfs4/BMC/wrfruc/mtoy/RT_BASELINE/Michael.Toy/FV3_RT/REGRESSION_TEST_INTEL.2022_03_19

Dependencies

None.

.gitmodules Outdated
Comment on lines 11 to 12
url = https://github.com/mdtoyNOAA/ccpp-physics
branch = RRFS_dev_drag_suite_sfc_composites_bugfixes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code manager needs to revert this before merging.

@SamuelTrahanNOAA SamuelTrahanNOAA merged commit 484e1de into NOAA-GSL:RRFS_dev Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants