Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in MYNN surface layer scheme. Also, added lat/log to RUC LSM for debugging. #112

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Bug fixes in MYNN surface layer scheme. Also, added lat/log to RUC LSM for debugging. #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df022f1
Pass into the RUC driver lat/lons for debugging.
tanyasmirnova Oct 31, 2021
d4964e1
Fixed bugs in MYNN surface layer scheme in land/ice/water parts of th…
tanyasmirnova Oct 31, 2021
75ccdc0
Restored modified by accident print statement.
tanyasmirnova Nov 1, 2021
d9c7bb3
Fixed the bug in horizontal dimension for xlon_d.
tanyasmirnova Nov 2, 2021
4155201
Added computations of local TSK_wat, TSK_ice and TSK_lnd at ITIMESTEP=1
tanyasmirnova Nov 2, 2021
3c29791
Move PSFC computation to the beginning before it is used.
tanyasmirnova Nov 3, 2021
3a037ae
1. Pass in flag_iter to MYNNSFC_wrapper for consistency with iteratio…
tanyasmirnova Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions physics/module_MYNNSFC_wrapper.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ end subroutine mynnsfc_wrapper_finalize
!###===================================================================
SUBROUTINE mynnsfc_wrapper_run( &
& im,levs, &
& itimestep,iter, &
& itimestep,iter,flag_iter, &
& flag_init,flag_restart,lsm,lsm_ruc,&
& sigmaf,vegtype,shdmax,ivegsrc, & !intent(in)
& z0pert,ztpert, & !intent(in)
Expand Down Expand Up @@ -111,6 +111,15 @@ SUBROUTINE mynnsfc_wrapper_run( &
! & EP_2 => con_eps

! USE module_sf_mynn, only : SFCLAY_mynn
!tgs - info on iterations:
! flag_iter- logical, execution or not (im)
! when iter = 1, flag_iter = .true. for all grids im !
! when iter = 2, flag_iter = .true. when wind < 2 im !
! for both land and ocean (when nstf_name1 > 0) im !
! flag_guess-logical, .true.= guess step to get CD et al im !
! when iter = 1, flag_guess = .true. when wind < 2 im !
! when iter = 2, flag_guess = .false. for all grids im !


!-------------------------------------------------------------------
implicit none
Expand Down Expand Up @@ -141,6 +150,7 @@ SUBROUTINE mynnsfc_wrapper_run( &

integer, intent(in) :: im, levs
integer, intent(in) :: iter, itimestep, lsm, lsm_ruc
logical, dimension(:), intent(in) :: flag_iter
logical, intent(in) :: flag_init,flag_restart,lprnt
integer, intent(in) :: ivegsrc
integer, intent(in) :: sfc_z0_type ! option for calculating surface roughness length over ocean
Expand Down Expand Up @@ -194,7 +204,7 @@ SUBROUTINE mynnsfc_wrapper_run( &
real, dimension(im) :: &
& hfx, znt, psim, psih, &
& chs, ck, cd, mavail, xland, GZ1OZ0, &
& cpm, qgh, qfx, qsfc_ruc, snowh_wat
& cpm, qgh, qfx, snowh_wat

real(kind=kind_phys), dimension(im,levs) :: &
& pattern_spp_pbl, dz, th, qv
Expand Down Expand Up @@ -249,10 +259,9 @@ SUBROUTINE mynnsfc_wrapper_run( &
where (icy) znt_ice=znt_ice*0.01

! qsfc ruc
qsfc_ruc = 0.0
if (lsm==lsm_ruc) then
where (dry) qsfc_ruc = qsfc_lnd_ruc
where (icy) qsfc_ruc = qsfc_ice_ruc
where (dry) qsfc_lnd = qsfc_lnd_ruc/(1.+qsfc_lnd_ruc) ! spec. hum
where (icy) qsfc_ice = qsfc_ice_ruc/(1.+qsfc_ice_ruc) ! spec. hum.
end if

! if (lprnt) then
Expand Down Expand Up @@ -291,12 +300,12 @@ SUBROUTINE mynnsfc_wrapper_run( &
CP=cp,G=g,ROVCP=rcp,R=r_d,XLV=xlv, &
SVP1=svp1,SVP2=svp2,SVP3=svp3,SVPT0=svpt0, &
EP1=ep_1,EP2=ep_2,KARMAN=karman, &
ISFFLX=isfflx,isftcflx=isftcflx,LSM=lsm, &
ISFFLX=isfflx,isftcflx=isftcflx,LSM=lsm,LSM_RUC=lsm_ruc, &
iz0tlnd=iz0tlnd,psi_opt=psi_opt, &
& sigmaf=sigmaf,vegtype=vegtype,shdmax=shdmax,ivegsrc=ivegsrc, & !intent(in)
& z0pert=z0pert,ztpert=ztpert, & !intent(in)
& redrag=redrag,sfc_z0_type=sfc_z0_type, & !intent(in)
itimestep=itimestep,iter=iter, &
itimestep=itimestep,iter=iter,flag_iter=flag_iter, &
wet=wet, dry=dry, icy=icy, & !intent(in)
tskin_wat=tskin_wat, tskin_lnd=tskin_lnd, tskin_ice=tskin_ice, & !intent(in)
tsurf_wat=tsurf_wat, tsurf_lnd=tsurf_lnd, tsurf_ice=tsurf_ice, & !intent(in)
Expand All @@ -318,7 +327,7 @@ SUBROUTINE mynnsfc_wrapper_run( &
ZNT=znt,USTM=ustm,ZOL=zol,MOL=mol,RMOL=rmol, &
psim=psim,psih=psih, &
HFLX=hflx,HFX=hfx,QFLX=qflx,QFX=qfx,LH=lh,FLHC=flhc,FLQC=flqc, &
QGH=qgh,QSFC=qsfc,QSFC_RUC=qsfc_ruc, &
QGH=qgh,QSFC=qsfc, &
U10=u10,V10=v10,TH2=th2,T2=t2,Q2=q2, &
GZ1OZ0=GZ1OZ0,WSPD=wspd,wstar=wstar, &
spp_pbl=spp_pbl,pattern_spp_pbl=pattern_spp_pbl, &
Expand Down
8 changes: 8 additions & 0 deletions physics/module_MYNNSFC_wrapper.meta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@
type = integer
intent = in
optional = F
[flag_iter]
standard_name = flag_for_iteration
long_name = flag for iteration
units = flag
dimensions = (horizontal_loop_extent)
type = logical
intent = in
optional = F
[flag_init]
standard_name = flag_for_first_timestep
long_name = flag signaling first time step for time integration loop
Expand Down
Loading