-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver to run SHiELD (and SHiEMOM) with the full FMS coupler #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. A couple of questions:
- Are the new files principally to replicate functionality needed by the coupler that exists in AM4 but not in SHiELD?
- Can we can now use the tracer_driver (ie. AM4 aerosols and chemistry) within SHiELD? I see that the tracer_driver routines are principally stubs and don't do anything.
Hi Lucas, yes true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the atmos_tracer_driver.html come from the repo you branched off? Or did you write this file yourself?
It comes from NOAA-GFDL/atmos_null: |
I think we can safely remove it as we tend to keep zero html files around anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JosephMouallem These updates needlessly clutter the atmos driver which is a fairly simple repo to only run the atmosphere. The code is mostly copy and paste from physics, so I think these updates should go in the physics.
The code does not follow the style guidelines, especially the documentation part about using doxygen style including descriptions for all routines and modules
https://github.com/NOAA-GFDL/atmos_drivers/blob/main/CODE_STYLE.md
@thomas-robinson Thanks for your feedback, we can certainly move the extra files out of SHiELDFULL/ and only leave atmos_model.F90. We could place them under SHiELD_physics/atmos_shared/ similar to what is done in NOAA-GFDL/atmos_phys. |
@JosephMouallem @thomas-robinson I think |
@thomas-robinson The extra atmos files were removed and added to SHiELD_physics. Description of variables and subroutines is revised and now follows the code style of other atmos_model.F90 under coupled/ and SHiELD/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I set up #42 related to updating the comment/documentation in this repo.
Add files under /SHiELDFULL/ to compile and run SHiELD with the full FMS coupler.
The same files allow running the new model SHiEMOM (SHiELD+MOM6) as well.
The user should set fullcoupler_fluxes=.true. in the namelist atmos_model_nml to apply the fluxes (computed on the exchange grid in the full coupler) back on the atmosphere.
Tested on Gaea, Stellar and Orion.
(On Orion before the latest big environment update)
Checklist: