Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to repo #28

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add CI to repo #28

merged 2 commits into from
Dec 20, 2023

Conversation

laurenchilutti
Copy link
Contributor

Description

Adding CI tests to this repo. This brings over a similar workflow as is done in the GFDL_atmos_cubed_sphere repository. Will build solo model (nh, sw, and hydro) and then run the 35 tests in RTS/CI.

Fixes # (issue)

How Has This Been Tested?

Tested by the successful checks on this PR

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Lauren. Thanks for putting this together. Are these runs intended to test the full-physics SHiELD or just the solo_core?

@laurenchilutti
Copy link
Contributor Author

laurenchilutti commented Oct 5, 2023

This will only test the solo shield. I could add in more tests to test build full shield configurations. And I can look into how feasible it would be to run a full shield model on the cloud - main concerns would be getting the input data onto the cloud and how expensive storage of input data may be.

I am now realizing that solo tests on SHiELD_physics PRs probably would not adequately test any changes to SHiELD_physics.

@lharris4
Copy link
Contributor

lharris4 commented Oct 5, 2023 via email

@lharris4
Copy link
Contributor

I realize I never merged this. Let me take care of this.

@lharris4 lharris4 merged commit 23a9ec0 into NOAA-GFDL:main Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants