Revive the marine jcb implementation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
requested review from
danholdaway,
AndrewEichmann-NOAA and
CoryMartin-NOAA
This was referenced Sep 13, 2024
|
As I'm adjusting the cases, I'm realizing that I'm not making use of the soca_2cice yaml ... Is that the proper location for these yamls?
|
guillaumevernieres
requested review from
CoryMartin-NOAA and
AndrewEichmann-NOAA
danholdaway
approved these changes
Sep 17, 2024
|
@danholdaway just an FYI I think the JCB-GDAS CI tests always fail, not sure why (haven't looked into it) |
CoryMartin-NOAA
approved these changes
Sep 17, 2024
guillaumevernieres
referenced
this pull request
in NOAA-EMC/GDASApp
Sep 18, 2024
This PR needs to be merged before - [https://github.com/NOAA-EMC/global-workflow/pull/2920](https://github.com/NOAA-EMC/global-workflow/pull/2920) It depends on - [https://github.com/NOAA-EMC/jcb-gdas/pull/26](https://github.com/NOAA-EMC/jcb-gdas/pull/26) and will require an update to the `jcb-gdas` submodules. It will break the GDASApp marine CI until the `g-w` pr is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates/fixes to the marine yaml templates.