Remove SDATE=CDATE IAU settings block in config.base.nco.static #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the block in config.base.nco.static that checks if CDATE=SDATE and turns IAU settings to 0. - This block is not needed in operations and causes issues in pre-implementation developer testing when starting a new warm-started parallel with wave restarts. Refs: #960
* develop: Updates for P8 (#946)
3 tasks
WalterKolczynski-NOAA
changed the title
WalterKolczynski-NOAA
approved these changes
Aug 3, 2022
KateFriedman-NOAA
added a commit
that referenced
this pull request
Aug 4, 2022
jkhender
added a commit
to jkhender/global-workflow
that referenced
this pull request
Dec 7, 2022
Bring in additional commits to update to NOAA-EMC global-workflow develop branch, prototype/8 tag
commit 17c8fa2e0518fddbb389b384efebb6a45bb71d79
Author: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
Date: Tue Aug 9 10:36:50 2022 -0400
Fix post comparison with zero-padded numbers (NOAA-EMC#964)
An error was introduced with PR NOAA-EMC#929 that was causing 0p50 and 1p00 grib
files to not be produced due to an error in comparing a zero-padded string.
Switching to arithmatic comparison solves the issue. Also updated the method
of the zero-padding to the preferred printf since the code was in close
proximity.
commit b90b2e9ae0f9421c7932c99d4d676e7890e3dfe9
Author: Kate Friedman <kate.friedman@noaa.gov>
Date: Wed Aug 3 14:45:48 2022 -0400
Remove SDATE=CDATE IAU block in NCO config.base (NOAA-EMC#963)
- Remove the block in config.base.nco.static that checks if CDATE=SDATE and turns IAU settings to 0.
- This block is not needed in operations and causes issues in pre-implementation developer testing when starting a new warm-started parallel with wave restarts.
Refs: NOAA-EMC#960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a bug reported in issue #960 revolving around IAU and FHROT settings in
config.base.nco.staticwhich result in a failing forecast job when running a new parallel that is warm-started with wave restarts. The following block is removed inconfig.base.nco.static:The above block is unnecessary in operations (and thankfully not an issue in operations since SDATE is very old) but caused issues when used in pre-implementation parallels that used
config.base.nco.staticand warm-started with wave restarts.Resolves #960
Type of change
How Has This Been Tested?
The developer running the affected parallel commented out this block and confirmed the forecast job no longer fails.
Checklist