Make job names consistent. #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om %RUN%. This commit uses %RUN% to make it consistent and possibly will open the door for further consolidation between gdas and gfs families
WalterKolczynski-NOAA
requested changes
Jan 18, 2022
WalterKolczynski-NOAA
approved these changes
Jan 18, 2022
KateFriedman-NOAA
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a inconsistency in the line
#PBS -N, where sometimes one of the following is used to attribute the jobname.#PBS -N gdas_- if this job belongs to thegdasfamily#PBS -N gfs_- if this job belongs to thegfsfamily#PBS -N %RUN%_- Lets the job inherit from the variable defined in the suite (and this variable is ( and has to be) defined in the suite.This PR:
gdasorgfsand uses%RUN%. This will also open the door to unify several of theecfscripts from thegdasandgfsfamilies. For e.g. several of thegdasandgfsfamilies can share the sameecfscript, with differences sometimes in resources (if at all). And those differences can be moved up to the suite definition (if desired).This work is part of #398
Including @WeiWei-NCO for feedback