-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update free forecast EXPDIR setup for coupled model #376
Update free forecast EXPDIR setup for coupled model #376
Conversation
- add if-block resource settings for ocnpost, init_chem, and mom6ic jobs - adjust settings for waveinit, waveprep, and wavepostbndpnt jobs Refs: NOAA-EMC#368
- further updates to config.fcst to be done still Refs: NOAA-EMC#368
- add new coupled switches - add new FIX directory paths - further updates to be done still Refs: NOAA-EMC#368
- update ATMPETS and MEDPETS to do calculations based on how it's done in crow - revert dddmp back to prior value to retain v16 settings - change sppt_logit from ".TRUE." to ".true" for consistency - remove temporary setting KMP_INIT_AT_FORK=FALSE - change DO_SKEB, DO_SHUM, and DO_SPPT back to "YES", will use YES/NO at workflow level Refs: NOAA-EMC#368
- remove RUN_CCPP variable, no longer needed - add DO_MOM6, DO_CICE, DO_GOCART - add APP settings and if-blocks to set DO_* coupled switches and CCPP_SUITE - use DO_* coupled switches to set cpl variables Refs: NOAA-EMC#368
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First cut at the review.
Some questions.
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
- develop branch currently runs with DO_S* switches set to NO in deterministic fcst jobs Refs: NOAA-EMC#368
- change cplgocart to be DO_GOCART instead - use YES/NO workflow level values here instead of .true./.false. code level values Refs: NOAA-EMC#368
- cplwav2atm isn't related to DO_WAVE - removed line where cplwav2atm is set to .true. when DO_WAVE=YES - cplwav2atm will default to .false. in config.base for now Refs: NOAA-EMC#368
- will put in config.resources if needed Refs: NOAA-EMC#368
- retaining GFSv16 ops settings for existing variables Refs: NOAA-EMC#368
- moved cpl variables from config.base to config.fcst - removed stochastic physics settings that had been added - changed '$cpl == .true.' to '$DO_COUPLED == "YES"' Refs: NOAA-EMC#368
- moved cpl variables from config.base to config.fcst - removed stochastic physics settings that had been added - changed '$cpl == .true.' to '$DO_COUPLED == "YES"' - removed remap and regrid sections Refs: NOAA-EMC#368
- rename DO_MOM6 -> DO_OCN - rename DO_CICE -> DO_ICE - rename DO_GOCART -> DO_AERO Refs: NOAA-EMC#368
- set all cpl* variable defaults to .false. - set cpl=.true. if DO_COUPLED=YES - set cplice=.true. if DO_ICE=YES - set cplgocart=.true. if DO_AERO=YES - set cplwav=.true. if DO_WAVE=YES - set cplflx=.true. if DO_OCN=YES or DO_ICE=YES Refs: NOAA-EMC#368
- WCOSS-Dell = /gpfs/dell2/emc/modeling/noscrub/Walter.Kolczynski/global-workflow/IC - Hera = /scratch2/NCEPDEV/climate/climpara/S2S/IC - Orion = /work/noaa/global/wkolczyn/noscrub/global-workflow/IC Need more official non-personal paths in future. Refs: NOAA-EMC#368
- move WAVE_CDUMP up into APP case block when APP includes waves - move nems_temp up into APP case block and set value for each APP - remove nems_temp_cold variable - set defaults for WAVE_CDUMP (empty) and nems_temp ("atm") Refs: NOAA-EMC#368
- add ATM case into APP case block to avoid error when config.base is sourced and APP=ATM - get "Unrecognized app" warning without this included Refs: NOAA-EMC#368
Final edits have been made. Please perform final review of incoming changes, thanks! I tested setup_expt_fcstonly.py and setup_workflow_fcstonly.py on Orion successfully with final config versions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just one nit pick comment. Feel free to commit or reject.
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Close #368 |
… feedback to FV3ATM (NOAA-EMC#376) Add a cplocn2atm namelist option to turn on/off the ocean model component feedback (e.g., SST) to the atmosphere model component.
Bring in new configuration settings/variables from feature/coupled-crow for coupled system. Did not need to change setup_expt*py scripts for this effort.
The following were copied in as is from example coupled EXPDIR config.base but need quick discussion:
Please review new APP if-blocks in config.base for DO_* switches.
Testing these changes against develop branch and modular forecast script runs now.
Issue #368