-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the gdas.cd hash and enable GDASApp to run on WCOSS2 #3220
base: develop
Are you sure you want to change the base?
Update the gdas.cd hash and enable GDASApp to run on WCOSS2 #3220
Conversation
This PR is opened in draft mode until g-w CI has been run on WCOSS2, Hera, Hercules, and Orion. The g-w team is invited to review and comment on changes to |
No issues here with the hash update. |
# Add path to GDASApp libraries | ||
export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:${HOMEgfs}/sorc/gdas.cd/build/lib" | ||
export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/opt/cray/pe/mpich/8.1.19/ofi/intel/19.0/lib" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, but will not be acceptable for implementation. I hope there is a more robust solution than this by that time.
More importantly, this has an impact on every executable in every job -- not just GDASApp executables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree. I strongly dislike these two lines. They are temporary patches to allow GFS v17 testing and development to continue on WCOSS2.
The line
export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:${HOMEgfs}/sorc/gdas.cd/build/lib"
was added because craype/2.7.17
adds
-static-libgcc -static-libstdc++ -Bstatic -lstdc++ -Bdynamic -lm -lpthread
to the ftn
command. GDASApp executables failed because they could not find JEDI libraries. Might the addition of a GDASApp install option (something we must have) resolve this problem?
Another concern with the added ftn
options is the following warning found in build_gdas.log
icpc: warning #10315: specifying -lm before files may supersede the Intel(R) math library and affect performance
ifort: warning #10315: specifying -lm before files may supersede the Intel(R) math library and affect performance
It would be unfortunate if default compiler options resulted in degraded code performance.
The line
export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/opt/cray/pe/mpich/8.1.19/ofi/intel/19.0/lib"
was recommended by GDIT. GDASApp testing identified inconsistencies in across system modules. Some GDASApp executables failed with undefined symbol messages for mpi routines. GDIT is working on a solution.
Description
This PR does the following:
sorc/gdas.cd
hash to bring new GDASApp functionality into g-wenv/WCOSS2.env
ush/module-setup.sh
The change to
WCOSS2.env
is due to changes introduced during the fall 2024 WCOSS2 upgrade. The change tomodule-setup.sh
is required when using spack-stack on WCOSS2.Resolves #3219
Resolves #3100
Type of change
gdas.cd
hash)Change characteristics
sorc/gdas.cd
hash. No PRs are pending.How has this been tested?
Checklist