Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gsi_enkf hash and gsi_ver #3207

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Update gsi_enkf hash and gsi_ver #3207

merged 5 commits into from
Jan 8, 2025

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jan 6, 2025 •
edited
Loading

Description

This PR updates the sorc/gsi_enkf.fd hash. gsi_ver is updated to be consistent with the gsi_enkf.fd hash.

Resolves #3027

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES/NO
    • GSI - no PR pending ... updating to current head of GSI develop

How has this been tested?

  • Clone and build on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 6, 2025
aerorahul
aerorahul approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Jan 6, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 6, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

CI Failed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/3207


Experiment C48mx500_3DVarAOWCDA_ec287582 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:17:56 UTC 2025
Experiment C48_ATM_ec287582 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:17:56 UTC 2025
Experiment C48mx500_hybAOWCDA_ec287582 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 00:24:24 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_ec287582 Completed 1 Cycles: *SUCCESS* at Tue Jan  7 00:30:40 UTC 2025

@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Jan 7, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3207


Experiment C48_ATM_ec287582 Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:44:18 CST 2025
Experiment C48mx500_3DVarAOWCDA_ec287582 Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:50:19 CST 2025
Experiment C48mx500_hybAOWCDA_ec287582 Completed 2 Cycles: *SUCCESS* at Mon Jan  6 17:56:39 CST 2025
Experiment C96_S2SWA_gefs_replay_ics_ec287582 Completed 1 Cycles: *SUCCESS* at Mon Jan  6 18:33:27 CST 2025
Experiment C96_atm3DVar_ec287582 Completed 3 Cycles: *SUCCESS* at Mon Jan  6 18:51:05 CST 2025
Experiment C96C48_hybatmDA_ec287582 Completed 3 Cycles: *SUCCESS* at Mon Jan  6 18:51:26 CST 2025
Experiment C48_S2SW_ec287582 Completed 2 Cycles: *SUCCESS* at Mon Jan  6 19:21:56 CST 2025
Experiment C48_S2SWA_gefs_ec287582 Completed 1 Cycles: *SUCCESS* at Mon Jan  6 20:41:47 CST 2025

@RussTreadon-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA and @TerrenceMcGuinness-NOAA : It's not clear to me why CI-Hera failed.

A check of case directories in /scratch1/NCEPDEV/global/CI/3207/RUNTESTS/EXPDIR indicates that some configurations did not continue submitting jobs after being started. Other configurations did not submit any jobs. Still other configurations successfully ran to completion. Is Jenkins working OK on Hera?

@TerrenceMcGuinness-NOAA
Copy link
Collaborator

@RussTreadon-NOAA Looking into this now.

@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Jan 7, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 7, 2025
@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 7, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

CI Passed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/3207


Experiment C48_S2SW_ec287582 Terminated with  tasks failed and  dead at Tue Jan  7 16:11:49 UTC 2025
Experiment C48_S2SW_ec287582 Terminated: **
Experiment C48_ATM_de984c12 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 18:35:12 UTC 2025
Experiment C48mx500_3DVarAOWCDA_de984c12 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 18:41:49 UTC 2025
Experiment C48mx500_hybAOWCDA_de984c12 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 18:47:55 UTC 2025
Experiment C96_S2SWA_gefs_replay_ics_de984c12 Completed 1 Cycles: *SUCCESS* at Tue Jan  7 18:47:57 UTC 2025
Experiment C96C48_hybatmDA_de984c12 Completed 3 Cycles: *SUCCESS* at Tue Jan  7 20:02:23 UTC 2025
Experiment C96C48_hybatmaerosnowDA_de984c12 Completed 3 Cycles: *SUCCESS* at Tue Jan  7 20:02:33 UTC 2025
Experiment C96_atm3DVar_de984c12 Completed 3 Cycles: *SUCCESS* at Tue Jan  7 20:08:15 UTC 2025
Experiment C96C48_ufs_hybatmDA_de984c12 Completed 3 Cycles: *SUCCESS* at Tue Jan  7 20:45:25 UTC 2025
Experiment C48_S2SW_de984c12 Completed 2 Cycles: *SUCCESS* at Tue Jan  7 20:52:14 UTC 2025
Experiment C48_S2SWA_gefs_de984c12 Completed 1 Cycles: *SUCCESS* at Tue Jan  7 21:23:37 UTC 2025

@RussTreadon-NOAA
Copy link
Contributor Author

@CatherineThomas-NOAA and @ADCollard : are both of you OK with merging this PR into g-w develop? This PR updates the gsi_enkf.fd hash and gsi fix files to the current head of GSI develop.

Are there any changes to exglobal_atmos_analysis.sh or exgdas_enkf_update.sh which should be inlcuded in this PR?

@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Jan 7, 2025
@emcbot
Copy link

emcbot commented Jan 7, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3207/RUNTESTS on WCOSS

@CatherineThomas-NOAA
Copy link
Contributor

@ClaraDraper-NOAA: Your ens mean increment changes don't require any accompanying changes in the global-workflow if soil DA is off, correct?

@ClaraDraper-NOAA
Copy link
Contributor

@ClaraDraper-NOAA: Your ens mean increment changes don't require any accompanying changes in the global-workflow if soil DA is off, correct?

This is correct, yes.

@KateFriedman-NOAA
Copy link
Member

CI tests run overnight on PR (prior to develop sync merge) completed successfully:

Wed Jan  8 16:00:14 UTC 2025
******** C48_ATM_3207 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jan 07 2025 22:30:24    Jan 07 2025 23:40:21
202103231800        Done    Jan 07 2025 22:30:24    Jan 07 2025 23:50:13

******** C48_S2SW_3207 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jan 07 2025 22:30:26    Jan 08 2025 00:15:17
202103231800        Done    Jan 07 2025 22:30:26    Jan 08 2025 00:25:26

******** C96_atm3DVar_extended_3207 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jan 07 2025 22:30:30    Jan 07 2025 22:50:34
202112210000        Done    Jan 07 2025 22:30:30    Jan 08 2025 02:55:29
202112210600        Done    Jan 07 2025 22:30:30    Jan 08 2025 03:45:28
202112211200        Done    Jan 07 2025 22:55:38    Jan 08 2025 04:30:28
202112211800        Done    Jan 08 2025 03:00:23    Jan 08 2025 15:35:29

******** C96C48_hybatmDA_3207 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jan 07 2025 22:30:32    Jan 07 2025 22:50:38
202112210000        Done    Jan 07 2025 22:30:32    Jan 08 2025 01:00:34
202112210600        Done    Jan 07 2025 22:30:32    Jan 08 2025 00:50:53

@KateFriedman-NOAA KateFriedman-NOAA added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Jan 8, 2025
@aerorahul aerorahul merged commit 673470a into NOAA-EMC:develop Jan 8, 2025
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/update_gsi_enkf branch January 10, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA

@ADCollard ADCollard Awaiting requested review from ADCollard

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sorc/gsi_enkf.fd hash
7 participants
@RussTreadon-NOAA @emcbot @TerrenceMcGuinness-NOAA @CatherineThomas-NOAA @ClaraDraper-NOAA @KateFriedman-NOAA @aerorahul