Fix GEFS and SFS compile flags in build_all.sh #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidHuber-NOAA
requested review from
WalterKolczynski-NOAA,
aerorahul and
KateFriedman-NOAA
as code owners
aerorahul
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
oooh, this is a big bugfix.
@sbanihash I think this is the cause of your failures. The gefs build option was missing a -w.
Good hunting @DavidHuber-NOAA @AntonMFernando-NOAA
|
@aerorahul that's a relief! @EricSinsky-NOAA I know you mentioned this -w to me, but we just figured that we don't need to add anything while building with the new develop branch. I will test with the changes and hopefully get it running:) |
|
Thank you all for finding the cause of this issue and adding a fix for it. Adding "-w" (build with wave structured grid) as an argument for ufs_gefs should resolve the issue that prevented the GEFS forecast job from running successfully since PR #3186 . |
tsga
added a commit
to tsga/global-workflow
that referenced
this pull request
Jan 4, 2025
* develop: Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199) Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171) Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193) Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197) Remove early-cycle EnKF forecast (NOAA-EMC#3185) Fix mod_icec bug in atmos_prod (NOAA-EMC#3167) Create compute build option (NOAA-EMC#3186) Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build_all.sh script was fixed to send the correct flags to build_ufs.sh for GEFS (added a missing
-w) and SFS (added a missing-y) executables. Issue reported by @AntonMFernando-NOAA.Type of change
Change characteristics
How has this been tested?
Build test on Hercules
Checklist