-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable bias correction for aerosol DA #3189
base: develop
Are you sure you want to change the base?
Conversation
@ypwang19: Do we have PRs in GDASApp and jcb-gdas for the changes required by this PR? If yes, we should cite these PRs in this g-w PR. Then the g-w team and others can see when the prerequisite PRs are merged. |
Yes, we have. I am going to open PRs in GDASApp and jcb-gdas soon and will cite them here. |
# Description This PR adds the aerosol bias file names to the jcb-base template. # Companion PRs NOAA-EMC/global-workflow#3189 # Issues Resolves #NOAA-EMC/global-workflow#3172 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] C96C48_hybatmaerosnowDA <!-- JEDI aero/snow cycled DA !--> --------- Co-authored-by: ypwang19 <yaping.wang@users.noreply.github.com> Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
This PR updates jcb yamls for aerosol variational bias correction. Will add the obs bias section to yamls in observations/aero/ later as more work is needed to select proper predictors. Companion PRs: - NOAA-EMC/GDASApp#1426 - NOAA-EMC/global-workflow#3189 Co-authored-by: ypwang19 <yaping.wang@users.noreply.github.com> Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
@ypwang19 , now that
have been merged into their respective Once this is done the |
I am not sure how to update the hash. |
@ypwang19 yes, I'll message you on Slack about how to do this. |
@ypwang19 could you update the values in https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gfs/config.aeroanlgenb as part of this PR? The numbers in |
Sure, I just updated the numbers to what we are using. |
@ypwang19 thanks! |
Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
Description
This PR enables the capability of bias correction for aerosol DA in the workflow.
Resolves #3172
Refs #2875
Type of change
Change characteristics
How has this been tested?
Checklist