Add sfcprep to config.resources.nco.static #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now consistent with the same resources set in config.resources.emc.dyn. - Also added "sfcprep" and "prep" to task list in both versions of config.resources. Refs NOAA-EMC#2913
KateFriedman-NOAA
requested review from
WalterKolczynski-NOAA,
GeorgeGayno-NOAA and
DavidHuber-NOAA
WalterKolczynski-NOAA
approved these changes
Oct 23, 2024
KateFriedman-NOAA
requested review from
DianeStokes-NCO
and removed request for
DianeStokes-NCO
KateFriedman-NOAA
merged commit 95caf6c
into
NOAA-EMC:release/gfs.v16.3.20
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per a request from the NCO SPA (Diane Stokes) assigned to the GFSv16.3.20 implementation, the sfcprep block that was added to
config.resources.emc.dynfor dev mode is now also added toconfig.resources.nco.static.This makes both resource configs consistent with each other for the emcsfc_sfc_prep job. This also removes a non-fatal error from the sourcing ofconfig.resourcesat runtime (due to the "sfcprep" job not being in the resource config at runtime).Will recut the hand-off tag after this PR goes into the release branch.
FYI @DianeStokes-NCO
Refs #2913
Type of change
Bug fix and NCO request