Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for obsproc/v1.3 and new AFWA snow filename #2957

Conversation

KateFriedman-NOAA
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA commented Sep 25, 2024

Description

This PR includes updates for the new obsproc/v1.3 and AFWA snow filename. A new UFS_UTILS tag (ops-gfsv16.3.20) is used for the snow filename changes. The prepobs package is also updating v1.2.0 but is internal to the obsproc package so only the prepobs_run_ver variables are updated for dev mode usage.

Additionally, workflow updates are made to allow the EMCSFC_SFC_PREP (sfcprep) job to be run as part of the rocoto mesh in dev/emc mode. A new switch DO_SFCPREP is added to config.base.emc.dyn and is set to "NO" by default. Setting it to "YES" will add the sfcprep job to the rocoto mesh ahead of the prep job and will generate the snogrb files that are usually generated in ops and used via the GDA.

Refs #2913

Type of change

Operational upstream change

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils - new tag ops-gfsv16.3.20
    • UFS-weather-model
    • wxflow

How has this been tested?

Tested in ops resolution cycled mode on WCOSS2-Cactus and reviewed by @GeorgeGayno-NOAA and @ilianagenkova

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Add it back if decision is made to update for saildrone.

Refs NOAA-EMC#2913
Copy link
Contributor

@ilianagenkova ilianagenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good as far as filename changes and obsproc versions are concerned.

@KateFriedman-NOAA
Copy link
Member Author

@GeorgeGayno-NOAA when you have a moment please review this PR. I've included updates to add the emcsfc_sfc_prep job to the rocoto mesh for dev mode. Thanks!

Add further information to describe change to AFWA global snow file

Refs NOAA-EMC#2913
@KateFriedman-NOAA KateFriedman-NOAA merged commit ef005f5 into NOAA-EMC:release/gfs.v16.3.20 Sep 26, 2024
1 check failed
@KateFriedman-NOAA KateFriedman-NOAA deleted the release/gfs.v16.3.20 branch September 26, 2024 13:33
KateFriedman-NOAA added a commit that referenced this pull request Oct 9, 2024
Merge remote-tracking branch 'origin/release/gfs.v16.3.20' into release/gfs.v16.3.21

Refs #2591

* origin/release/gfs.v16.3.20:
  Update GSI tag to gfsda.v16.3.20 for saildrone data (#2986)
  Update WAFS tag in release notes
  Set WAFS tag back to new gfs_wafs.v6.3.3
  Revert "Remove WAFS from ops (#2889)"
  Update for obsproc/v1.3 and new AFWA global snow filename (#2957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants