Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace APRUN with APRUN_default #2871

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Replace APRUN with APRUN_default #2871

merged 6 commits into from
Sep 11, 2024

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Aug 28, 2024 •
edited
Loading

Description

This replaces APRUN with APRUN_default in all of the .env files.

Resolves #2870

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • CI on Hera
  • CI on Hercules
  • CI on WCOSS2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review September 4, 2024 19:44
@DavidHuber-NOAA
Copy link
Contributor Author

All CI tests passed on WCOSS2 with the exception of the extended tests that are still running. Marking this PR ready for review.

KateFriedman-NOAA
KateFriedman-NOAA previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DavidHuber-NOAA !

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Sep 10, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Sep 10, 2024
@emcbot
Copy link

emcbot commented Sep 10, 2024 

CI Update on Wcoss2 at 09/10/24 02:32:08 AM
============================================
Cloning and Building global-workflow PR: 2871
with PID: 60155 on host: dlogin03

@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Sep 10, 2024
@emcbot
Copy link

emcbot commented Sep 10, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Tue Sep 10 02:35:05 UTC 2024 on dlogin03
---------------------------------------------------
Build: Completed at 09/10/24 03:12:04 AM
Case setup: Completed for experiment C48_ATM_06c7d401
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_06c7d401
Case setup: Skipped for experiment C48_S2SWA_gefs_06c7d401
Case setup: Completed for experiment C48_S2SW_06c7d401
Case setup: Completed for experiment C96_atm3DVar_extended_06c7d401
Case setup: Skipped for experiment C96_atm3DVar_06c7d401
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_06c7d401
Case setup: Completed for experiment C96C48_hybatmDA_06c7d401
Case setup: Completed for experiment C96C48_ufs_hybatmDA_06c7d401

@emcbot emcbot added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Sep 10, 2024
@emcbot
Copy link

emcbot commented Sep 10, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_06c7d401 *** SUCCESS *** at 09/10/24 04:42:15 AM
Experiment C48_S2SW_06c7d401 *** SUCCESS *** at 09/10/24 04:57:21 AM
Experiment C96C48_hybatmDA_06c7d401 *** SUCCESS *** at 09/10/24 05:48:29 AM
Experiment C96C48_hybatmaerosnowDA_06c7d401 *** SUCCESS *** at 09/10/24 06:51:19 AM
Experiment C96C48_ufs_hybatmDA_06c7d401 *** SUCCESS *** at 09/10/24 07:42:18 AM
Experiment C96_atm3DVar_extended_06c7d401 *** SUCCESS *** at 09/10/24 04:06:53 PM

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Sep 11, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Sep 11, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Sep 11, 2024
@emcbot
Copy link

emcbot commented Sep 11, 2024

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2871


Experiment C48_ATM_06c7d401 Completed 1 Cycles: *SUCCESS* at Tue Sep 10 23:23:12 CDT 2024
Experiment C96_atm3DVar_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 00:17:48 CDT 2024
Experiment C96C48_hybatmDA_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 00:18:00 CDT 2024
Experiment C48_S2SWA_gefs_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 00:36:36 CDT 2024
Experiment C48_S2SW_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 00:59:59 CDT 2024

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Sep 11, 2024
@emcbot
Copy link

emcbot commented Sep 11, 2024

CI Passed on Hera in Build# 2
Built and ran in directory /scratch1/NCEPDEV/global/CI/2871


Experiment C48mx500_3DVarAOWCDA_06c7d401 Completed 2 Cycles: *SUCCESS* at Wed Sep 11 04:12:22 UTC 2024
Experiment C48_ATM_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 04:18:27 UTC 2024
Experiment C96_atm3DVar_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 05:37:55 UTC 2024
Experiment C96C48_hybatmDA_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 05:38:16 UTC 2024
Experiment C48_S2SWA_gefs_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 05:50:59 UTC 2024
Experiment C48_S2SW_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 06:02:21 UTC 2024
Experiment C96C48_ufs_hybatmDA_06c7d401 Completed 2 Cycles: *SUCCESS* at Wed Sep 11 06:02:38 UTC 2024
Experiment C96C48_hybatmaerosnowDA_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 06:39:12 UTC 2024

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Sep 11, 2024
@emcbot
Copy link

emcbot commented Sep 11, 2024

CI Passed on Orion in Build# 3
Built and ran in directory /work2/noaa/stmp/CI/ORION/2871


Experiment C48_ATM_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 12:06:06 AM CDT 2024
Experiment C96C48_hybatmDA_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 01:26:47 AM CDT 2024
Experiment C96_atm3DVar_06c7d401 Completed 3 Cycles: *SUCCESS* at Wed Sep 11 01:33:00 AM CDT 2024
Experiment C48_S2SWA_gefs_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 01:33:01 AM CDT 2024
Experiment C48_S2SW_06c7d401 Completed 1 Cycles: *SUCCESS* at Wed Sep 11 01:45:24 AM CDT 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 6ea681b into NOAA-EMC:develop Sep 11, 2024
10 of 11 checks passed
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/aprun_def branch November 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA left review comments

@aerorahul aerorahul Awaiting requested review from aerorahul

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename APRUN to APRUN_default in the env files
4 participants
@DavidHuber-NOAA @emcbot @WalterKolczynski-NOAA @KateFriedman-NOAA