Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdas_gsibec_ver to 20240416 #2497

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Update gdas_gsibec_ver to 20240416 #2497

merged 4 commits into from
Apr 22, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Apr 16, 2024 •
edited by KateFriedman-NOAA
Loading

Description

This PR updates gdas_gsibec_ver to use the default qoption=1 when running fv3jedi_var.x. This is the recommended configuration when using the statiic GSI-B in fv3jedi_var.x.

Resolves #2496
Completes #2493

Type of change

  • Maintenance - gsibec update

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Check gdas_gsibec_ver=20240416 on Hera to confirm that correct GSIBEC namelist is used.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Apr 16, 2024
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Apr 16, 2024
Closed
4 tasks
@KateFriedman-NOAA KateFriedman-NOAA linked an issue Apr 17, 2024 that may be closed by this pull request
update gdas/gsibec qoption #2493
Closed
4 tasks
@KateFriedman-NOAA KateFriedman-NOAA self-requested a review April 17, 2024 12:36
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending any CI testing being successful.

@KateFriedman-NOAA
Copy link
Member

@RussTreadon-NOAA Do you want us to run CI tests for this update? I believe this only impacts JEDI runs via global-workflow.

We had CI tests on hold last week so I'm getting back to this PR now.

@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Apr 22, 2024 •
edited
Loading

@KateFriedman-NOAA - you are correct. This PR only impacts JEDI ATM.

JEDI ATM ci/cases/pr/C96C48_ufs_hybatmDA successfully runs on Hera and Orion as documented in g-w PRs #2420 and #2357. I think we should include JEDI ATM CI as part of routine g-w CI. We are actively submitting JEDI ATM g-w PRs (e.g., #2420, #2477, & #2497 (this PR)).

Given your question I am stepping through the following on Orion:

  • clone RussTreadon-NOAA:feature/gsibec
  • build g-w apps via sorc/build_all.sh -u
  • sorc/link_workflow.sh
  • remove the -orion entry in ci/cases/pr/C96C48_ufs_hybatmDA
  • run JEDI ATM CI

@RussTreadon-NOAA
Copy link
Contributor Author

JEDI ATM CI run on Orion. Cycling complete through GFS and GDAS atmanlrun. These are the JEDI ATM jobs which use gsibec. Both jobs ran to completion. JEDI ATM CI passed.

This test could have been automatically run if JEDI ATM CI was turned on in ci/cases/pr/C96C48_ufs_hybatmDA.yaml.

@KateFriedman-NOAA
Copy link
Member

@RussTreadon-NOAA Thank you for running that JEDI CI test on Orion and reporting its success.

I will speak with the other CMs about potentially turning that JEDI CI test on automatically for the platforms where JEDI currently works.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit b5a7338 into NOAA-EMC:develop Apr 22, 2024
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/gsibec branch April 22, 2024 19:41
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 23, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
0a920cd 
* upstream/develop:
  Add CCPP suite and FASTER option to UFS build (NOAA-EMC#2521)
  New "atmanlfv3inc" Rocoto job (NOAA-EMC#2420)
  Hotfix to disable STALLED in CI as an error (NOAA-EMC#2523)
  Add restart on failure capability for the forecast executable (NOAA-EMC#2510)
  Update parm/transfer list files to match vetted GFSv16 set (NOAA-EMC#2517)
  Update gdas_gsibec_ver to 20240416 (NOAA-EMC#2497)
  Adding more cycles to gempak script gfs_meta_sa2.sh (NOAA-EMC#2518)
  Update gsi_enkf.sh hash to 457510c (NOAA-EMC#2514)
  Enable using the FV3_global_nest_v1 CCPP suite (NOAA-EMC#2512)
  CI Refactoring and STALLED case detection (NOAA-EMC#2488)
  Add C768 and C1152 S2SW test cases (NOAA-EMC#2509)
  Fix paths for refactored prepocnobs task (NOAA-EMC#2504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update gdas_gsibec_ver to 20240416 update gdas/gsibec qoption
3 participants
@RussTreadon-NOAA @KateFriedman-NOAA @WalterKolczynski-NOAA