Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oceanalecn to workflow generator #2409

Merged
merged 20 commits into from
Apr 12, 2024
Merged

Add oceanalecn to workflow generator #2409

merged 20 commits into from
Apr 12, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Mar 18, 2024 •
edited
Loading

Description

Adds task oceanalecn to the workflow generator, plus some necessary env var work to the jjob. The workflow generator adds oceanalecn only if nens > 0 self.do_hybvar.

Resolves NOAA-EMC/GDASApp#912

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO

How has this been tested?

Example:

  • Cycled test with and without ocnanalecen task on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@AndrewEichmann-NOAA
Copy link
Contributor Author

AndrewEichmann-NOAA commented Mar 18, 2024 •
edited
Loading

FYI @guillaumevernieres @CoryMartin-NOAA

CoryMartin-NOAA
CoryMartin-NOAA reviewed Mar 19, 2024
View reviewed changes
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
workflow/applications/gfs_cycled.py Outdated Show resolved Hide resolved
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review March 21, 2024 21:13
guillaumevernieres
guillaumevernieres approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved pending successful completion of CI tests.

@guillaumevernieres
Copy link
Contributor

Conditionally approved pending successful completion of CI tests.

It's not yet tested as part of the g-w ci @WalterKolczynski-NOAA .

@WalterKolczynski-NOAA
Copy link
Contributor

Conditionally approved pending successful completion of CI tests.

It's not yet tested as part of the g-w ci @WalterKolczynski-NOAA .

I'd still like to test it to make sure it doesn't break any existing tests.

@AndrewEichmann-NOAA Please merge in the current develop and then we can test this PR and get it merged.

@guillaumevernieres
Copy link
Contributor

Conditionally approved pending successful completion of CI tests.

It's not yet tested as part of the g-w ci @WalterKolczynski-NOAA .

I'd still like to test it to make sure it doesn't break any existing tests.

@AndrewEichmann-NOAA Please merge in the current develop and then we can test this PR and get it merged.

Could this PR be merged @WalterKolczynski-NOAA ?

aerorahul
aerorahul reviewed Apr 10, 2024
View reviewed changes
sorc/link_workflow.sh Outdated Show resolved Hide resolved
aerorahul
aerorahul reviewed Apr 10, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
aerorahul
aerorahul requested changes Apr 10, 2024
View reviewed changes
jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN Outdated Show resolved Hide resolved
WalterKolczynski-NOAA
WalterKolczynski-NOAA previously requested changes Apr 11, 2024
View reviewed changes
sorc/link_workflow.sh Outdated Show resolved Hide resolved
@AndrewEichmann-NOAA @WalterKolczynski-NOAA
Update sorc/link_workflow.sh
595813b 
Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
aerorahul
aerorahul approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the issues.

@aerorahul aerorahul dismissed WalterKolczynski-NOAA’s stale review April 12, 2024 14:38

requested changes have been addressed.

@aerorahul aerorahul merged commit 36f3841 into NOAA-EMC:develop Apr 12, 2024
4 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 15, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
c784cc8 
* upstream/develop:
  Update fbwind for COM refactor (NOAA-EMC#2479)
  Update parm files for atm product (NOAA-EMC#2486)
  Fix paths in prepocnobs task (NOAA-EMC#2459)
  Add oceanalecn to workflow generator (NOAA-EMC#2409)
  Add support for CADS IR cloud detection scheme in the GSI (NOAA-EMC#2478)
  Improve error messaging to resolve bugzilla (NOAA-EMC#2468)
  Check the DO_JEDISNOWDA condition before adding snow DA analysis to the list (NOAA-EMC#2471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@aerorahul aerorahul aerorahul approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA WalterKolczynski-NOAA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recenter ens. members around the deterministic background.
5 participants
@AndrewEichmann-NOAA @guillaumevernieres @WalterKolczynski-NOAA @CoryMartin-NOAA @aerorahul