Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShellCheck Action and Add differential PyLint Action #1290

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

jamacku
Copy link
Contributor

@jamacku jamacku commented Jan 30, 2023

Description

GitHub Action fedora-copr/vcs-diff-lint-action works similarly to redhat-plumbers-in-action/differential-shellcheck. It reports only newly added PyLint defects in SARIF format.

Based on our conversation in - #1007, I think you might be interested.

Type of change

  • ci

How Has This Been Tested?

Manually by opening PR

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite well versed in this, so I have nothing to comment on this PR.

Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new actions to allowed list.

@WalterKolczynski-NOAA
Copy link
Contributor

@jamacku thanks for the follow-up!

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 807b529 into NOAA-EMC:develop Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants