-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atmosphere cycling with a Coupled model #1274
Changes from 8 commits
9a7abd7
87752bc
7fa1c14
48b0ab0
c463640
07206c3
897e454
e4475b3
220c518
2c82642
adaccd6
756cd83
52aef5b
87c3aea
4e8d388
d906c3b
6865065
cd69548
3e6bb7e
22c91a0
accadfb
44ceaaf
013c276
24be763
d8a14d7
42beaf9
9854da5
0254f89
8afd36a
044ce69
75165f7
54aea10
9c6d78c
897a226
5b61bfd
7686cea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ __pycache__ | |
*.sw[a-p] | ||
._* | ||
.DS_Store | ||
nohup.out | ||
.idea/ | ||
.vscode/ | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ | |
# Empty variables must include a space otherwise they will be overwritten | ||
|
||
# config.base | ||
# CASE=C384 | ||
FHMAX_GFS_00=48 | ||
FHMAX_GFS_06=48 | ||
FHMAX_GFS_12=48 | ||
|
@@ -15,21 +14,27 @@ FHOUT_HF_GFS=-1 | |
min_seaice="1.0e-6" | ||
use_cice_alb=".true." | ||
|
||
# config.fv3 | ||
DELTIM=300 | ||
layout_x_gfs=8 | ||
layout_y_gfs=8 | ||
WRITE_GROUP_GFS=1 | ||
WRTTASK_PER_GROUP_GFS=24 | ||
#The settings below will result in S2SWA running 35 days under 8 hours wallclock on hera | ||
#layout_x_gfs=24 | ||
#layout_y_gfs=16 | ||
#WRTTASK_PER_GROUP_GFS=86 | ||
WRTIOBUF="32M" | ||
MEDPETS=300 | ||
|
||
# config.fv3 # TODO: This is hard-wired for P8 and needs to be refactored. For now, use case C384 | ||
case "${CASE}" in | ||
"C384") | ||
DELTIM=300 | ||
layout_x_gfs=8 | ||
layout_y_gfs=8 | ||
WRITE_GROUP_GFS=1 | ||
WRTTASK_PER_GROUP_GFS=24 | ||
#The settings below will result in S2SWA running 35 days under 8 hours wallclock on hera | ||
#layout_x_gfs=24 | ||
#layout_y_gfs=16 | ||
#WRTTASK_PER_GROUP_GFS=86 | ||
WRTIOBUF="32M" # TODO: This value is for P8 w/ C384. Why not update/set this as default in config.fv3 C384? | ||
MEDPETS=300 # TODO: P8 wants to use 300 instead of ATMPETS = layout_x * layout_y * 6 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: The reason we use less than ATMPETS is it's been found to be more efficient, so this is likely not going to be limited to a "p8" case. That'll be for future GEFS and GFS once optimized settings are determined again (the current ones here were "sufficient" but not "optimal"). |
||
;; | ||
esac | ||
|
||
# config.ice | ||
|
||
# TODO: These also are likely P8 hard-wired configurations. Perhaps this file should be config.P8.defaults | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a fair statement. In some sense this is the "I want to run the coupled model" file which before would mess-up other configurations stand-alone. |
||
# config.wave | ||
|
||
waveGRD='gwes_30m' | ||
waveinterpGRD=' ' | ||
waveuoutpGRD='gwes_30m' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,18 @@ | ||
#! /usr/bin/env bash | ||
|
||
export NX_GLB="1440" | ||
export NY_GLB="1080" | ||
case "${ICERES}" in | ||
"025") | ||
export NX_GLB="1440" | ||
export NY_GLB="1080" | ||
;; | ||
"500") # TODO: From GV, check w/ DW | ||
export NX_GLB="36" | ||
export NY_GLB="70" | ||
export block_size_x="18" # TODO: These are calculated in parsing_namelists_CICE.sh, but the model does not like those values | ||
export block_size_y="35" | ||
;; | ||
*) | ||
echo "FATAL ERROR: Unsupported ICERES = ${ICERES}, ABORT!" | ||
exit 1 | ||
;; | ||
esac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file added to
.gitignore
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nohup.out
is a file usually produced when one runs a script or an executable usingnohup
.nohup
allows running a job in the background and closing the terminal will allow the job to continue running.This is especially useful for scripts such as
build_all.sh
that take a while.It can be viewed as a file similar to a "log".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aerorahul . I am familiar with
nohup.out
. I often run the GDASApp build in the background withnohup
. I was just wondering why we put it in the.gitignore
list. I like to seenohup.out
in thegit status
listing. When I commit, I manuallygit add
each file I intend to commit. Wasnohup.out
added to.gitignore
to avoid accidentally committing this file to the repo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @RussTreadon-NOAA that I like seeing files like this in my "git status".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RussTreadon-NOAA @JessicaMeixner-NOAA
nohup.out
was added to.gitignore
to avoid accidentally committing this file to the repo similar to the other files listed above; such as executables, logs, compiled artifacts.Users should be able to do an
ls
and still see this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file could always be removed later if accidentally committed and could be avoided by manually adding each commit field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere I have seen, this file is part of
.gitignore
to precisely preventing manual removing an accidental addition of this (and other types of files).@RussTreadon-NOAA Is your comment suggesting we don't add this to
.gitignore
? Am I missing something?Either way, this should not be a blocker for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerorahul . Yes, I don't think
nohup.out
should be in.gitignore
. If it's standard practice to place this file in.gitignore
, I'm OK with this. I agree. This is not a blocker for this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. we will review this user request against best practice and hold this for another time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @aerorahul.
nohup.out
is just another kind of logfile that should never be committed to the repo, which is the point of.gitignore
.