Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GFS v16.3 operational gsi scripts into develop branch #1158

Merged
merged 1 commit into from
Jan 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion jobs/JGDAS_ENKF_FCST
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ status=$?
export CDATE=${CDATE:-${PDY}${cyc}}
export CDUMP=${CDUMP:-${RUN:-"gdas"}}
export COMPONENT="atmos"
export rCDUMP="gdas"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hard coded line is for gfsefmn jobs in early enkf. This will cause jobs can not find the data in previous cycle enkf/gdas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right @XianwuXue-NOAA
My apologies for missing this in the review.
We can open a hotfix asap.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. the gdas[gfs]anal[eobs] jobs also failed, after reverse the changes in exglobal_atmos_analysis.sh, I can run it successfully. I tried to change crtm_ver from 2.3.0 to 2.4.0, however, it does not pass the value. I think I modified the wrong file (ecf/versions/gfs.ver).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialize of the rCDUMP is for rCDUMP used in forecast_predet.sh that is default to CDUMP.
A GW meeting has decision made to revert this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: When I change the cram version from 2.3.0 to 2.4.0 in modulefiles/module_base.wcoss2.lua, then gdas[gfs]anal[eobs] jobs works with the exglobal_atmos_analysis.sh changes in this PR.


##############################################
# Begin JOB SPECIFIC work
Expand Down
8 changes: 3 additions & 5 deletions scripts/exglobal_atmos_analysis.sh
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ lupp=${lupp:-".true."}
cnvw_option=${cnvw_option:-".false."}

# Observation usage options
cao_check=${cao_check:-".false."}
ta2tb=${ta2tb:-".false."}
cao_check=${cao_check:-".true."}
ta2tb=${ta2tb:-".true."}

# Diagnostic files options
lobsdiag_forenkf=${lobsdiag_forenkf:-".false."}
Expand Down Expand Up @@ -451,9 +451,7 @@ ${NLN} ${RTMFIX}/NPOESS.VISsnow.EmisCoeff.bin ./crtm_coeffs/NPOESS.VISsnow.Emis
${NLN} ${RTMFIX}/NPOESS.VISwater.EmisCoeff.bin ./crtm_coeffs/NPOESS.VISwater.EmisCoeff.bin
${NLN} ${RTMFIX}/FASTEM6.MWwater.EmisCoeff.bin ./crtm_coeffs/FASTEM6.MWwater.EmisCoeff.bin
${NLN} ${RTMFIX}/AerosolCoeff.bin ./crtm_coeffs/AerosolCoeff.bin
${NLN} ${RTMFIX}/CloudCoeff.bin ./crtm_coeffs/CloudCoeff.bin
#$NLN $RTMFIX/CloudCoeff.GFDLFV3.-109z-1.bin ./crtm_coeffs/CloudCoeff.bin

${NLN} ${RTMFIX}/CloudCoeff.GFDLFV3.-109z-1.bin ./crtm_coeffs/CloudCoeff.bin

##############################################################
# Observational data
Expand Down