Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address shellcheck warnings in env files #1136

Merged

Commits on Nov 16, 2022

  1. Configuration menu
    Copy the full SHA
    fd648d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Configuration menu
    Copy the full SHA
    2b140aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcfed57 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Configuration menu
    Copy the full SHA
    046f4ba View commit details
    Browse the repository at this point in the history
  2. Update env files for shellcheck SC2250

    - SC2250 – Prefer putting braces around variable references even when not strictly required.
    - Add curly braces around variables where missing in env files.
    
    Refs NOAA-EMC#397
    KateFriedman-NOAA committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0033786 View commit details
    Browse the repository at this point in the history
  3. Update env files for shellcheck SC2086

    - SC2086 – Double quote to prevent globbing and word splitting.
    - Add double quotes around variables where missing in env files.
    
    Refs NOAA-EMC#397
    KateFriedman-NOAA committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    5dc099d View commit details
    Browse the repository at this point in the history
  4. Update env files for shellcheck SC2292

    - SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
    - Change [ ] to [[ ]] where needed in env files.
    
    Refs NOAA-EMC#397
    KateFriedman-NOAA committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    9dd25de View commit details
    Browse the repository at this point in the history
  5. Update env files for shellcheck SC2166 and more SC2292

    - SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
    - SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
    - Change "-o" to "||" and "-a" to "&&".
    - Also apply more SC2292 double brace updates to lines that had SC2166 updates.
    
    Refs NOAA-EMC#397
    KateFriedman-NOAA committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2ae6b6b View commit details
    Browse the repository at this point in the history
  6. Update env files for shellcheck SC2004

    - SC2004 (style): $/${} is unnecessary on arithmetic variables.
    - Update arithmetic expressions accordingly in env files.
    
    Refs NOAA-EMC#397
    KateFriedman-NOAA committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6cd424d View commit details
    Browse the repository at this point in the history
  7. Update WCOSS2 env file for SC2034

    - SC2034 (warning): NTASKS appears unused. Verify use (or export if used externally).
    - Add "export" for NTASKS variable setting in waveprep if-block.
    
    Refs NOAA-EMC#397
    KateFriedman-NOAA committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    5ebd819 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    4a65ac4 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Configuration menu
    Copy the full SHA
    213f36b View commit details
    Browse the repository at this point in the history