-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of EFSOI in global-workflow #1074
Implementation of EFSOI in global-workflow #1074
Conversation
Getting EFSOI branch merged with develop
Conflicts: env/ORION.env jobs/JGDAS_EFSOI_ECEN jobs/JGDAS_EFSOI_FCST jobs/JGDAS_EFSOI_POST jobs/JGDAS_EFSOI_SFC jobs/JGDAS_EFSOI_UPDATE jobs/rocoto/earc.sh parm/config/config.resources sorc/checkout.sh sorc/link_workflow.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
@AndrewEichmann-NOAA @CatherineThomas-NOAA Once this PR is merged, the branch will be protected and only @AndrewEichmann-NOAA will be allowed write access to this protected branch (with a PR of course). |
@aerorahul Since the previous PR was reviewed multiple times and the only changes from that are small ones in sorc/build_gsi_utils.sh and sorc/checkout.sh, it can probably live without further review. |
YAY! Testing now.... |
Description
This PR addresses issue #673 (addition of EFSOI utility global-workflow) to and replaces PR #674 . It is substantially the same as PR 674, with the addition of files sorc/build_gsi_utils.sh and sorc/checkout.sh, which had been left until updates with the gsi-utils repository.
The following files are modified:
The following files are added:
Type of change
How Has This Been Tested?
Checklist