Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of EFSOI in global-workflow #1074

Merged
merged 127 commits into from
Oct 17, 2022

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Oct 17, 2022

Description

This PR addresses issue #673 (addition of EFSOI utility global-workflow) to and replaces PR #674 . It is substantially the same as PR 674, with the addition of files sorc/build_gsi_utils.sh and sorc/checkout.sh, which had been left until updates with the gsi-utils repository.

The following files are modified:

  • env/ORION.env
  • jobs/JGDAS_EFSOI
  • jobs/JGDAS_EFSOI_ECEN
  • jobs/JGDAS_EFSOI_FCST
  • jobs/JGDAS_EFSOI_POST
  • jobs/JGDAS_EFSOI_SFC
  • jobs/JGDAS_EFSOI_UPDATE
  • jobs/rocoto/earc.sh
  • parm/config/config.base.emc.dyn
  • parm/config/config.earc
  • parm/config/config.resources
  • scripts/exgdas_efsoi.sh
  • scripts/exgdas_efsoi_update.sh
  • sorc/build_gsi_utils.sh
  • sorc/checkout.sh
  • sorc/link_workflow.sh
  • ush/forecast_predet.sh
  • ush/hpssarch_gen.sh
  • workflow/applications.py
  • workflow/rocoto/workflow_tasks.py

The following files are added:

  • jobs/rocoto/ecenfsoi.sh
  • jobs/rocoto/efcsfsoi.sh
  • jobs/rocoto/efsoi.sh
  • jobs/rocoto/eposfsoi.sh
  • jobs/rocoto/esfcfsoi.sh
  • jobs/rocoto/eupdfsoi.sh
  • parm/config/config.ecenfsoi
  • parm/config/config.efcsfsoi
  • parm/config/config.efsoi
  • parm/config/config.eposfsoi
  • parm/config/config.esfcfsoi
  • parm/config/config.eupdfsoi

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Cycled test on Orion

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@aerorahul
Copy link
Contributor

@AndrewEichmann-NOAA @CatherineThomas-NOAA
Since this branch is solely for the purposes of EFSOI, I am happy to merge this PR without a review.
If you would like it reviewed, please let me know and I can assign your suggested reviewers.

Once this PR is merged, the branch will be protected and only @AndrewEichmann-NOAA will be allowed write access to this protected branch (with a PR of course).

@AndrewEichmann-NOAA
Copy link
Contributor Author

@aerorahul Since the previous PR was reviewed multiple times and the only changes from that are small ones in sorc/build_gsi_utils.sh and sorc/checkout.sh, it can probably live without further review.

@aerorahul aerorahul merged commit 6ff6651 into NOAA-EMC:feature/efsoi Oct 17, 2022
@AndrewEichmann-NOAA
Copy link
Contributor Author

YAY! Testing now....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants