Rename post scripts #1037
Rename post scripts #1037
Conversation
WalterKolczynski-NOAA
requested review from
aerorahul and
KateFriedman-NOAA
Rename post scripts to remove the unnecessary "ncep" qualifier.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -117,9 +117,9 @@ | |||
| ############################################################### | |||
| # Run relevant exglobal script | |||
|
|
|||
| $SCRgfs/ex${RUN}_atmos_nceppost.sh | |||
| $SCRgfs/ex${RUN}_atmos_post.sh | |||
Check warning
Code scanning / shellcheck
SCRgfs is referenced but not assigned.
| @@ -117,9 +117,9 @@ | |||
| ############################################################### | |||
| # Run relevant exglobal script | |||
|
|
|||
| $SCRgfs/ex${RUN}_atmos_nceppost.sh | |||
| $SCRgfs/ex${RUN}_atmos_post.sh | |||
Check warning
Code scanning / shellcheck
Double quote to prevent globbing and word splitting.
| @@ -117,9 +117,9 @@ | |||
| ############################################################### | |||
| # Run relevant exglobal script | |||
|
|
|||
| $SCRgfs/ex${RUN}_atmos_nceppost.sh | |||
| $SCRgfs/ex${RUN}_atmos_post.sh | |||
Check warning
Code scanning / shellcheck
Prefer putting braces around variable references even when not strictly required.
| @@ -117,9 +117,9 @@ | |||
| ############################################################### | |||
| # Run relevant exglobal script | |||
|
|
|||
| $SCRgfs/ex${RUN}_atmos_nceppost.sh | |||
| $SCRgfs/ex${RUN}_atmos_post.sh | |||
Check warning
Code scanning / shellcheck
Double quote to prevent globbing and word splitting.
|
|
||
| cd $DATA | ||
|
|
||
| export POSTGPSH=${POSTGPSH:-$USHgfs/gfs_nceppost.sh} | ||
| export POSTGPSH=${POSTGPSH:-$USHgfs/gfs_post.sh} |
Check warning
Code scanning / shellcheck
Prefer putting braces around variable references even when not strictly required.
WalterKolczynski-NOAA
force-pushed
the
feature/rename_post
branch
from
a94369b to
3fee66f
Compare
|
Kate is already making most of these linter fixes in PR #1030, so I'm going to close this PR and hold until that is merged. |
Description
Rename post scripts to remove the unnecessary "ncep" qualifier. Also changes the executable name for upp to be the one produced by upp (
upp.x).The ush/global_nceppost.sh script is removed as it is not used by any job. We may want to rename the gfs_post.sh script (the one that is used) to global_post.sh to be more reflective of its usage.
Type of change
How Has This Been Tested?
Checklist