Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fix reorg and remove gfs-utils code #1009

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c0634fa
Update fix subfolders to ignore in .gitignore
KateFriedman-NOAA Aug 25, 2022
104ca75
Update link_workflow.sh for fix set reorg
KateFriedman-NOAA Aug 25, 2022
eafd6b3
Update JEDI fix subfolder path name in configs
KateFriedman-NOAA Aug 25, 2022
4e472f8
Update fix subfolders in configs to remove "fix_"
KateFriedman-NOAA Aug 25, 2022
f918698
Remove "fix_" from fix subfolder paths in scripts
KateFriedman-NOAA Aug 25, 2022
209d62b
Create versions folder and fix.ver
KateFriedman-NOAA Aug 25, 2022
18a599a
Remove gfs-utils code and update for new fix
WalterKolczynski-NOAA Aug 31, 2022
1b7c418
Correct merge error in link script
WalterKolczynski-NOAA Aug 31, 2022
f411e0a
Update gfs utils to pick up Orion gempak fix
WalterKolczynski-NOAA Sep 6, 2022
053947e
Update to new UFS_UTILS hash
WalterKolczynski-NOAA Sep 20, 2022
acadfdb
Revert change to checkout for GSI-adjacent repos
WalterKolczynski-NOAA Sep 20, 2022
d7e1f29
Add gfs-utils to manage externals config
WalterKolczynski-NOAA Sep 20, 2022
797dd70
First wave of linter fixes
WalterKolczynski-NOAA Sep 20, 2022
0babfaa
Linter fixes for fix dir reorg
WalterKolczynski-NOAA Sep 23, 2022
7a60a28
Wave 3 of linter fixes for fix update
WalterKolczynski-NOAA Sep 23, 2022
fe467bd
Wave 4 linter fixes for fix update
WalterKolczynski-NOAA Sep 23, 2022
b79ef4f
Fix minor syntax error in link script
WalterKolczynski-NOAA Sep 24, 2022
190f97f
Update new GLDAS scripts for new fix pattern
WalterKolczynski-NOAA Sep 26, 2022
c8ce296
Fix default missing var syntax error
WalterKolczynski-NOAA Sep 27, 2022
c80ad79
Move root fixdir setting higher in link script
WalterKolczynski-NOAA Sep 27, 2022
73a0b71
Fix erronous CR in log directory
WalterKolczynski-NOAA Oct 4, 2022
71b5114
Merge branch 'develop' into feature/use_gw_utils
WalterKolczynski-NOAA Oct 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 19 additions & 58 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,23 @@ install*/
# Ignore fix directory symlinks
#------------------------------
fix/0readme
fix/fix_*
fix/gdas/
fix/aer
fix/am
fix/chem
fix/cice
fix/cpl
fix/datm
fix/gdas
fix/gldas
fix/gsi
fix/lut
fix/mom6
fix/orog
fix/reg2grb2
fix/sfc_climo
fix/ugwd
fix/verif
fix/wave
fix/wafs

# Ignore parm file symlinks
Expand Down Expand Up @@ -75,62 +90,8 @@ parm/wafs
#--------------------------------------------
sorc/*log
sorc/logs
sorc/ufs_model.fd
sorc/gfs_post.fd
sorc/gfs_wafs.fd
sorc/gldas.fd
sorc/gsi_enkf.fd
sorc/gsi.fd
sorc/enkf.fd
sorc/gdas.cd
sorc/gsi_utils.fd
sorc/gsi_monitor.fd
sorc/ufs_utils.fd
sorc/verif-global.fd

# Ignore sorc symlinks
#---------------------
sorc/calc_analysis.fd
sorc/calc_increment_ens.fd
sorc/calc_increment_ens_ncio.fd
sorc/emcsfc_ice_blend.fd
sorc/emcsfc_snow2mdl.fd
sorc/fregrid.fd
sorc/gdas2gldas.fd
sorc/getsfcensmeanp.fd
sorc/getsigensmeanp_smooth.fd
sorc/getsigensstatp.fd
sorc/gfs_ncep_post.fd
sorc/gldas2gdas.fd
sorc/gldas_forcing.fd
sorc/gldas_model.fd
sorc/gldas_post.fd
sorc/gldas_rst.fd
sorc/global_chgres.fd
sorc/global_cycle.fd
sorc/global_enkf.fd
sorc/global_gsi.fd
sorc/interp_inc.fd
sorc/make_hgrid.fd
sorc/make_solo_mosaic.fd
sorc/ncdiag_cat.fd
sorc/nst_tf_chg.fd
sorc/oznmon_horiz.fd
sorc/oznmon_time.fd
sorc/radmon_angle.fd
sorc/radmon_bcoef.fd
sorc/radmon_bcor.fd
sorc/radmon_time.fd
sorc/recentersigp.fd
sorc/upp.fd
sorc/wafs_awc_wafavn.fd
sorc/wafs_blending.fd
sorc/wafs_blending_0p25.fd
sorc/wafs_cnvgrib2.fd
sorc/wafs_gcip.fd
sorc/wafs_grib2_0p25.fd
sorc/wafs_makewafs.fd
sorc/wafs_setmissing.fd
sorc/*.cd
sorc/*.fd

# Ignore scripts from externals
#------------------------------
Expand Down
9 changes: 8 additions & 1 deletion Externals.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,15 @@ repo_url = https://github.com/ufs-community/ufs-weather-model.git
protocol = git
required = True

[gfs-utils]
hash = 93898e1
local_path = sorc/gfs_utils.fd
repo_url = https://github.com/NOAA-EMC/gfs-utils
protocol = git
required = True

[UFS-Utils]
hash = ufs_utils_1_8_0
hash = 8b990c0
local_path = sorc/ufs_utils.fd
repo_url = https://github.com/NOAA-EMC/UFS_UTILS.git
protocol = git
Expand Down
2 changes: 1 addition & 1 deletion jobs/JGDAS_ATMOS_GLDAS
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export COMPONENT=${COMPONENT:-atmos}
##############################################
export gldas_ver=${gldas_ver:-v2.3.0}
export HOMEgldas=${HOMEgldas:-${HOMEgfs}}
export FIXgldas=${FIXgldas:-${HOMEgldas}/fix/fix_gldas}
export FIXgldas=${FIXgldas:-${HOMEgldas}/fix/gldas}
export PARMgldas=${PARMgldas:-${HOMEgldas}/parm/gldas}
export EXECgldas=${EXECgldas:-${HOMEgldas}/exec}
export USHgldas=${USHgldas:-${HOMEgldas}/ush}
Expand Down
2 changes: 1 addition & 1 deletion parm/config/config.aeroanl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export OBS_YAML_DIR=$HOMEgfs/sorc/gdas.cd/parm/aero/obs/config/
export OBS_LIST=$HOMEgfs/sorc/gdas.cd/parm/aero/obs/lists/aero_prototype.yaml
export AEROVARYAML=$HOMEgfs/sorc/gdas.cd/parm/aero/variational/3dvar_dripcg.yaml
export BERROR_YAML=$HOMEgfs/sorc/gdas.cd/parm/aero/berror/static_bump.yaml
export FV3JEDI_FIX=$HOMEgfs/fix/fix_jedi
export FV3JEDI_FIX=$HOMEgfs/fix/gdas

export io_layout_x=1
export io_layout_y=1
Expand Down
2 changes: 1 addition & 1 deletion parm/config/config.atmanal
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export OBS_YAML_DIR=$HOMEgfs/sorc/gdas.cd/parm/atm/obs/config/
export OBS_LIST=$HOMEgfs/sorc/gdas.cd/parm/atm/obs/lists/gdas_prototype.yaml
export ATMVARYAML=$HOMEgfs/sorc/gdas.cd/parm/atm/variational/3dvar_dripcg.yaml
export BERROR_YAML=$HOMEgfs/sorc/gdas.cd/parm/atm/berror/hybvar_bump.yaml
export FV3JEDI_FIX=$HOMEgfs/fix/fix_jedi
export FV3JEDI_FIX=$HOMEgfs/fix/gdas
export R2D2_OBS_DB='ufsda_test'
export R2D2_OBS_DUMP='oper_gdas'
export R2D2_OBS_SRC='ncdiag'
Expand Down
2 changes: 1 addition & 1 deletion parm/config/config.atmensanal
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export OBS_YAML_DIR=$HOMEgfs/sorc/gdas.cd/parm/atm/obs/config/
export OBS_LIST=$HOMEgfs/sorc/gdas.cd/parm/atm/obs/lists/lgetkf_prototype.yaml
export BERROR_YAML=$HOMEgfs/sorc/gdas.cd/parm/atm/berror/hybvar_bump.yaml
export ATMENSYAML=$HOMEgfs/sorc/gdas.cd/parm/atm/lgetkf/lgetkf.yaml
export FV3JEDI_FIX=$HOMEgfs/fix/fix_jedi
export FV3JEDI_FIX=$HOMEgfs/fix/gdas
export R2D2_OBS_DB='ufsda_test'
export R2D2_OBS_DUMP='oper_gdas'
export R2D2_OBS_SRC='ncdiag'
Expand Down
8 changes: 4 additions & 4 deletions parm/config/config.base.emc.dyn
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ export UTILgfs=$HOMEgfs/util
export EXECgfs=$HOMEgfs/exec
export SCRgfs=$HOMEgfs/scripts

export FIXcice=$HOMEgfs/fix/fix_cice
export FIXmom=$HOMEgfs/fix/fix_mom6
export FIXreg2grb2=$HOMEgfs/fix/fix_reg2grb2
export FIXcice=$HOMEgfs/fix/cice
export FIXmom=$HOMEgfs/fix/mom6
export FIXreg2grb2=$HOMEgfs/fix/reg2grb2

########################################################################

Expand Down Expand Up @@ -74,7 +74,7 @@ export MODE="@MODE@" # cycled/forecast-only
# CLEAR
####################################################
# Build paths relative to $HOMEgfs
export FIXgsi="$HOMEgfs/fix/fix_gsi"
export FIXgsi="$HOMEgfs/fix/gsi"
export HOMEfv3gfs="$HOMEgfs/sorc/fv3gfs.fd"
export HOMEpost="$HOMEgfs"
export HOMEobsproc_prep="$BASE_GIT/obsproc/obsproc_prep.v5.5.0_hpc-stack"
Expand Down
2 changes: 1 addition & 1 deletion parm/config/config.base.nco.static
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export REALTIME="YES"
# CLEAR
####################################################
# Build paths relative to $HOMEgfs
export FIXgsi="$HOMEgfs/fix/fix_gsi"
export FIXgsi="$HOMEgfs/fix/gsi"
export HOMEfv3gfs="$HOMEgfs/sorc/fv3gfs.fd"
export HOMEpost="$HOMEgfs"
export HOMEobsproc_prep="$NWPROD/obsproc_prep.v5.5.0"
Expand Down
2 changes: 1 addition & 1 deletion parm/config/config.prep
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export COMINsyn=${COMINsyn:-$(compath.py ${envir}/com/gfs/${gfs_ver})/syndat}

export HOMERELO=$HOMEgfs
export EXECRELO=${HOMERELO}/exec
export FIXRELO=${HOMERELO}/fix/fix_am
export FIXRELO=${HOMERELO}/fix/am
export USHRELO=${HOMERELO}/ush

# Adjust observation error for GFS v16 parallels
Expand Down
4 changes: 2 additions & 2 deletions parm/config/config.vrfy
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ if [ $VRFYFITS = "YES" ]; then

export fit_ver="newm.1.3"
export fitdir="$BASE_GIT/verif/global/Fit2Obs/${fit_ver}/batrun"
export PRVT=$HOMEgfs/fix/fix_gsi/prepobs_errtable.global
export HYBLEVS=$HOMEgfs/fix/fix_am/global_hyblev.l${LEVS}.txt
export PRVT=$HOMEgfs/fix/gsi/prepobs_errtable.global
export HYBLEVS=$HOMEgfs/fix/am/global_hyblev.l${LEVS}.txt
export CUE2RUN=$QUEUE

export VBACKUP_FITS=24
Expand Down
2 changes: 1 addition & 1 deletion parm/config/config.wave
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ echo "BEGIN: config.wave"
export wave_sys_ver=v1.0.0

export EXECwave="$HOMEgfs/exec"
export FIXwave="$HOMEgfs/fix/fix_wave"
export FIXwave="$HOMEgfs/fix/wave"
export PARMwave="$HOMEgfs/parm/wave"
export USHwave="$HOMEgfs/ush"

Expand Down
2 changes: 1 addition & 1 deletion scripts/exgdas_atmos_chgres_forenkf.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ source "$HOMEgfs/ush/preamble.sh"

# Directories.
pwd=$(pwd)
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/fix_am}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/am}

# Base variables
CDATE=${CDATE:-"2001010100"}
Expand Down
4 changes: 2 additions & 2 deletions scripts/exgdas_atmos_gldas.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ nlat=$((2*res))
nlon=$((4*res))

export USHgldas=${USHgldas:?}
export FIXgldas=${FIXgldas:-${HOMEgfs}/fix/fix_gldas}
export topodir=${topodir:-${HOMEgfs}/fix/fix_fv3_gmted2010/${CASE}/}
export FIXgldas=${FIXgldas:-${HOMEgfs}/fix/gldas}
export topodir=${topodir:-${HOMEgfs}/fix/orog/${CASE}}

DATA=${DATA:-${pwd}/gldastmp$$}
mkdata=NO
Expand Down
4 changes: 2 additions & 2 deletions scripts/exgdas_enkf_ecen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ CYCLESH=${CYCLESH:-$HOMEgfs/ush/global_cycle.sh}
export CYCLEXEC=${CYCLEXEC:-$HOMEgfs/exec/global_cycle}
APRUN_CYCLE=${APRUN_CYCLE:-${APRUN:-""}}
NTHREADS_CYCLE=${NTHREADS_CYCLE:-${NTHREADS:-1}}
export FIXfv3=${FIXfv3:-$HOMEgfs/fix/fix_fv3_gmted2010}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/fix_am}
export FIXfv3=${FIXfv3:-$HOMEgfs/fix/orog}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/am}
export CYCLVARS=${CYCLVARS:-"FSNOL=-2.,FSNOS=99999.,"}
export FHOUR=${FHOUR:-0}
export DELTSFC=${DELTSFC:-6}
Expand Down
2 changes: 1 addition & 1 deletion scripts/exgdas_enkf_fcst.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ source "$HOMEgfs/ush/preamble.sh"
# Directories.
pwd=$(pwd)
export FIX_DIR=${FIX_DIR:-$HOMEgfs/fix}
export FIX_AM=${FIX_AM:-$FIX_DIR/fix_am}
export FIX_AM=${FIX_AM:-$FIX_DIR/am}

# Utilities
export NCP=${NCP:-"/bin/cp -p"}
Expand Down
4 changes: 2 additions & 2 deletions scripts/exgdas_enkf_sfc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ CYCLESH=${CYCLESH:-$HOMEgfs/ush/global_cycle.sh}
export CYCLEXEC=${CYCLEXEC:-$HOMEgfs/exec/global_cycle}
APRUN_CYCLE=${APRUN_CYCLE:-${APRUN:-""}}
NTHREADS_CYCLE=${NTHREADS_CYCLE:-${NTHREADS:-1}}
export FIXfv3=${FIXfv3:-$HOMEgfs/fix/fix_fv3_gmted2010}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/fix_am}
export FIXfv3=${FIXfv3:-$HOMEgfs/fix/orog}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/am}
export CYCLVARS=${CYCLVARS:-"FSNOL=-2.,FSNOS=99999.,"}
export FHOUR=${FHOUR:-0}
export DELTSFC=${DELTSFC:-6}
Expand Down
4 changes: 2 additions & 2 deletions scripts/exglobal_atmos_analysis_calc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ source "$HOMEgfs/ush/preamble.sh"

# Directories.
pwd=$(pwd)
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/fix_am}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/am}

# Base variables
CDATE=${CDATE:-"2001010100"}
Expand Down Expand Up @@ -72,7 +72,7 @@ CALCANLPY=${CALCANLPY:-$HOMEgfs/ush/calcanl_gfs.py}

DOGAUSFCANL=${DOGAUSFCANL-"NO"}
GAUSFCANLSH=${GAUSFCANLSH:-$HOMEgfs/ush/gaussian_sfcanl.sh}
export GAUSFCANLEXE=${GAUSFCANLEXE:-$HOMEgfs/exec/gaussian_sfcanl.exe}
export GAUSFCANLEXE=${GAUSFCANLEXE:-$HOMEgfs/exec/gaussian_sfcanl.x}
NTHREADS_GAUSFCANL=${NTHREADS_GAUSFCANL:-1}
APRUN_GAUSFCANL=${APRUN_GAUSFCANL:-${APRUN:-""}}

Expand Down
4 changes: 2 additions & 2 deletions scripts/exglobal_atmos_sfcanl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ export SNOW_NUDGE_COEFF=${SNOW_NUDGE_COEFF:-'-2.'}
export CYCLVARS=${CYCLVARS:-""}
export FHOUR=${FHOUR:-0}
export DELTSFC=${DELTSFC:-6}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/fix_am}
export FIXfv3=${FIXfv3:-$HOMEgfs/fix/fix_fv3_gmted2010}
export FIXgsm=${FIXgsm:-$HOMEgfs/fix/am}
export FIXfv3=${FIXfv3:-$HOMEgfs/fix/orog}

# FV3 specific info (required for global_cycle)
export CASE=${CASE:-"C384"}
Expand Down
2 changes: 1 addition & 1 deletion scripts/run_reg2grb2.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ source "$HOMEgfs/ush/preamble.sh"
#requires grib_util module

MOM6REGRID=${MOM6REGRID:-$HOMEgfs}
export mask_file=$MOM6REGRID/fix/fix_reg2grb2/mask.0p25x0p25.grb2
export mask_file=$MOM6REGRID/fix/reg2grb2/mask.0p25x0p25.grb2

# offline testing:
#export DATA=
Expand Down
Loading