Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases for JEDI DA configurations #1821

Closed
aerorahul opened this issue Aug 24, 2023 · 10 comments
Closed

Test cases for JEDI DA configurations #1821

aerorahul opened this issue Aug 24, 2023 · 10 comments
Assignees
Labels
feature New feature or request

Comments

@aerorahul
Copy link
Contributor

Description
A lot of new and exciting JEDI DA features have been added in the past few months.
JEDI-based DA for atmosphere with and without ensemble
JEDI-based DA for snow updates
JEDI-based DA for aerosol updates
JEDI-based DA for ocean and sea-ice

We would like to ensure that these capabilities are tested regularly with every update of the system where relevant. For e.g. an update in the ufs-weather-model hash would trigger all tests, but a change in the land_analysis will only likely impact snow DA, but that will be deferred to the SME.

Requirements
The developers of these systems should provide and maintain a cycled test case for each of these individual configurations. At an appropriate time, a weakly coupled test will be added combining these configurations based on the needs of the science teams.

Acceptance Criteria (Definition of Done)

  • configuration for each update mentioned above
  • data for supporting and running the above configurations in the global-workflow for atleast 1 and 1/2 cycled test at maximum of C96/5-deg resolution.

(Optional): Suggest A Solution

@AndrewEichmann-NOAA
Copy link
Contributor

@guillaumevernieres should I be in on this?

@guillaumevernieres
Copy link
Contributor

@guillaumevernieres should I be in on this?

probably @AndrewEichmann-NOAA , we'll figure it out internally.

WalterKolczynski-NOAA pushed a commit that referenced this issue Aug 31, 2023
This PR partially addresses #1821 in that it allows for a C48 simplified aerosol 3DVar test
using the workflow to run in GDASApp CI testing. The workflow team will be able to adapt
this test case for their CI testing with minimal effort.

This limits the C48 aerosol analysis to 6 PEs and updates the hash of GDASApp to a stable
build from this morning.

Refs #1821
@CoryMartin-NOAA
Copy link
Contributor

CoryMartin-NOAA commented Oct 13, 2023

@aerorahul if it's okay with you, I will wait to prepare the aerosol case once I've been able to implement and test FGAT as described in #1930 as that will be our target configuration (assuming the atm has IAU on). I expect to test/debug this early next week.

@RussTreadon-NOAA
Copy link
Contributor

PR #2199 adds C96_atmsnowDA.yaml. PR #1963 adds C48mx500_3DVarAOWCDA.yaml. Might either of these be leveraged to create cases CXX_atmUFSDA or CXXCYY_hybatmUFSDA. These cases would be JEDI-based DA for atmosphere without and with ensemble, respectively.

@RussTreadon-NOAA
Copy link
Contributor

@jiaruidong2017 , where may I find the staged ICs used to run the Hera tests reported in PR #2287?. This PR ran C96_atmsnowDA with, I presume, an ensemble. If true, it seems the same ICs could be used to create C96_atmUFSDA and C96_hybatmUFSDA CI cases.

@jiaruidong2017
Copy link
Contributor

@RussTreadon-NOAA you can find the ICs used in PR #2287 as below:

/scratch2/NCEPDEV/stmp1/Jiarui.Dong/gdas.init/landid9/C96C48/output/gdas.20211220/
/scratch2/NCEPDEV/stmp1/Jiarui.Dong/gdas.init/landid9/C96C48/output/enkfgdas.20211220/

@RussTreadon-NOAA
Copy link
Contributor

Thank you @jiaruidong2017 . These ICs work with the GFS v17 UFS weather model using the fractional grid global_cycle changes in PR #2262. Is this correct?

@jiaruidong2017
Copy link
Contributor

@RussTreadon-NOAA Yes, it is correct.

@RussTreadon-NOAA
Copy link
Contributor

g-w issue #2294 provides the JEDI-based DA for atmosphere with and without ensemble test requested by this issue.

@WalterKolczynski-NOAA
Copy link
Contributor

We have all the named tests above. If more tests are to be added, we can open new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants