Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the hierarchy of ensemble members in ROTDIR #1196

Closed
2 of 4 tasks
aerorahul opened this issue Dec 19, 2022 · 0 comments · Fixed by #1201
Closed
2 of 4 tasks

Correct the hierarchy of ensemble members in ROTDIR #1196

aerorahul opened this issue Dec 19, 2022 · 0 comments · Fixed by #1201
Assignees

Comments

@aerorahul
Copy link
Contributor

aerorahul commented Dec 19, 2022

Description
When the atmos component level was added to the ensemble directory structure, it was added "above" the ensemble member. As a result, the enkfgdas.$PDY/$cyc directory structure looks as follows:

└── enkfgdas.20211220
    └── 18
        └── atmos
            ├── mem001
            │   ├── INPUT
            │   └── RESTART
            └── mem002

When the coupled model components for wave, ocean, ice, chem etc. are added, this directory tree will need to be converted to look as follows:

└── enkfgdas.20211220
    └── 18
        ├── mem001
        │   ├── atmos
        │   │   ├── INPUT
        │   │   └── RESTART
        │   ├── chem
        │   ├── ice
        │   ├── ocean
        │   │   └── INPUT
        │   └── wave
        └── mem002

This will allow collecting all components for any ensemble member easily.

This will require work in many scripts within the global-workflow as this information is baked in.

Requirements

  • Update the COMROT structure to be consistent between the deterministic member and the ensemble members.
  • Update the scripts in the global-workflow to use the data from the updated COMROT structure.

Acceptance Criteria (Definition of Done)

  • Current cycled ATM configuration should work in the hybrid and 3DVar cases
  • Current forecast only configuration should work for apps ATM and S2SWA
@aerorahul aerorahul added this to the GFSv17 milestone Dec 19, 2022
@aerorahul aerorahul self-assigned this Dec 23, 2022
WalterKolczynski-NOAA pushed a commit that referenced this issue Jan 9, 2023
Moves the member directory one higher level in the directory hierarchy in anticipation of additionally components being run for the members in addition to atmos. This results in COM directories that are arranged as `memXXX/atmos` instead of `atmos/memXXX`.

This PR also adds a "hack" to allow the success for the `gdaspostanl` job in the first half cycle (see #1034). The "hack" will be removed with the refactoring of the post jobs in the (near) future.

Fixes #1196
Refs #1034
DavidHuber-NOAA pushed a commit to DavidHuber-NOAA/global-workflow that referenced this issue Jan 13, 2023
The logical test used to set gsi namelist variable `nhr_obsbin` was not consistent with other checks in the script which use variable `l4densvar`.  This relocates the setting for `nhr_obsbin` to be consistent with other tests using `l4densvar`, which will allow the appropriate error messages to be output by the executable.

Fixes NOAA-EMC#1123
Fixes [NCO bugzilla NOAA-EMC#1196](http://www2.spa.ncep.noaa.gov/bugzilla/show_bug.cgi?id=1196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant