Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with getic task if ROTDIR directory not cleaned up #1156

Closed
jkhender opened this issue Dec 8, 2022 · 1 comment · Fixed by #1165
Closed

Error with getic task if ROTDIR directory not cleaned up #1156

jkhender opened this issue Dec 8, 2022 · 1 comment · Fixed by #1165
Assignees
Labels
bug Something isn't working

Comments

@jkhender
Copy link
Contributor

jkhender commented Dec 8, 2022

Expected behavior
User should not have to clean up $ROTDIR before running getic again after it fails

Current behavior
After I ran the getic task and it failed (see issue #1155), the job was resubmitted. The job gave an error when running the following statement.

mv ${EXTRACT_DIR}/${CDUMP}.${yy}${mm}${dd}/${hh}/* ${ROTDIR}/${CDUMP}.${yy}${mm}${dd}/${hh}

mv: cannot move <EXTRACT_DIR>/gfs.20221115/00/* to <ROT_DIR>/gfs.20221115/00/atmos': Directory not empty

Machines affected
All

To Reproduce
run getic.sh before fixing it for issue #1155 and then resubmit job

@jkhender jkhender added the bug Something isn't working label Dec 8, 2022
@lgannoaa lgannoaa self-assigned this Dec 9, 2022
@lgannoaa
Copy link
Contributor

lgannoaa commented Dec 9, 2022

Job getic task successfully completed on first attempt. It is recommended only rerun the failed job as needed.
The job getic.sh should be updated with exception handlining in place to fail the job if the target directory is not empty.
Will provide a PR for the fix.

WalterKolczynski-NOAA pushed a commit that referenced this issue Dec 15, 2022
If getic is run with an existing `$ROTDIR` (possibly because it failed the first time), it would fail because the directory already exists. Now any existing directory is deleted before attempting to move the ICs.

Fixes #1156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants