You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Forecast hours (fhr) should be treated as a decimal, not octal, when executing math expressions.
Current behavior
In exgdas_atmos_post.sh:222, fhr is treated as an octal, resulting in an error when fhr=008, etc. This results in the if evaluating to false and IGEN=${IGEN_ANL}. In the end, this makes not difference as IGEN is not used in any meaningful way.
Machines affected
All
To Reproduce
Run a post job for forecast hour 008 or 009.
Possible Implementation
Remove all references to IGEN, unless there are plans to use this variable in the future. If so, then replace if (( fhr > 0 )); then
with
d_fhr=$((10#$fhr))
if (( d_fhr > 0 )); then
The text was updated successfully, but these errors were encountered:
`fhr` was still being treated as an octal in some places of atmos post. Instances where `fhr` are used for math are now updated to `d_fhr`, which is always a decimal representation of the `fhr` string.
Fixes#1141
Expected behavior
Forecast hours (
fhr
) should be treated as a decimal, not octal, when executing math expressions.Current behavior
In exgdas_atmos_post.sh:222,
fhr
is treated as an octal, resulting in an error whenfhr=008
, etc. This results in theif
evaluating tofalse
andIGEN=${IGEN_ANL}
. In the end, this makes not difference asIGEN
is not used in any meaningful way.Machines affected
All
To Reproduce
Run a post job for forecast hour 008 or 009.
Possible Implementation
Remove all references to
IGEN
, unless there are plans to use this variable in the future. If so, then replaceif (( fhr > 0 )); then
with
The text was updated successfully, but these errors were encountered: