Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage GSI fix files in global/glopara space and disable recursive clone of GSI #1128

Closed
aerorahul opened this issue Nov 22, 2022 · 10 comments · Fixed by #1132
Closed

Stage GSI fix files in global/glopara space and disable recursive clone of GSI #1128

aerorahul opened this issue Nov 22, 2022 · 10 comments · Fixed by #1132
Assignees
@aerorahul @KateFriedman-NOAA

Comments

@aerorahul
Copy link
Contributor

Description
The global DA group would like to stage GSI fix files in the global/glopara space similar to the model fix files.
Part of this is motivated from the unknown and recurring issues with cloning GSI-fix from gerrit.

Requirements

  1. Stage GSI-fix in the global/glopara space on RDHPCS and WCOSS2. Do so by cloning gerrit:GSI-fix at 023f81d (head of rev2 branch).
  2. Disable recursive clone of GSI in checkout.sh
  3. Update link_workflow.sh to create a link of the GSI-fix files from glopara space to the global-workflow fix/

Acceptance Criteria (Definition of Done)

  1. GSI fix files are staged in global/glopara spaces on RDHPCS (Hera, Orion, Jet, S4) and WCOSS2
  2. GSI should not clone fix files from global-workflow
  3. GSI-fix files should be linked from global/glopara spaces similar to model fix files.

@KateFriedman-NOAA maintains Hera, Orion and WCOSS2
@DavidHuber-NOAA maintains Jet and S4 spaces
@aerorahul will update the global-workflow develop to make the links and disable the recursive clone of GSI in global-workflow.
@aerorahul aerorahul mentioned this issue Nov 22, 2022
Merged
8 tasks
@DavidHuber-NOAA
Copy link
Contributor

@aerorahul I will pull the fix files into the S4 glopara space. However, I do not have write access in Jet's glopara space.

@KateFriedman-NOAA
Copy link
Member

I maintain the Jet (glopara) copy (in addition to the WCOSS2, Hera, and Orion ones). I can update the Jet copy.

@KateFriedman-NOAA
Copy link
Member

@RussTreadon-NOAA I'm working on the staging task now...is the VLabRepoQuickTips.txt necessary to be included? Also wondering about the example_unformatted_fileinfo.txt file. Let me know, thanks!

@RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA I'm working on the staging task now...is the VLabRepoQuickTips.txt necessary to be included? Also wondering about the example_unformatted_fileinfo.txt file. Let me know, thanks!

@KateFriedman-NOAA , for the time being I recommend preserving the integrity of GSI fix.

@KateFriedman-NOAA
Copy link
Member

@RussTreadon-NOAA Okie dokie. I have copied the contents of your /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/develop/fix folder (the requested hash/branch) into a new gsi/20221128 folder in the Hera fix set. Please see the following and let me know if it looks good: /scratch1/NCEPDEV/global/glopara/fix/gsi/20221128
FYI, I adjusted file/folder permissions to match the rest of the fix subfolders. Once I get the thumbs up that the Hera fix copy is good I'll rsync it to WCOSS2, Orion, and Jet. @DavidHuber-NOAA can rsync to S4.
@aerorahul did you want to test the Hera copy before I rsync to the other platforms?

@RussTreadon-NOAA
Copy link
Contributor

@KateFriedman-NOAA , thank you for adding the GSI fix files to the glopara account on Hera. A local copy of the GSI has been updated to run regression tests using glopara fix. I'll update this issue upon successful completion of this test.

@KateFriedman-NOAA
Copy link
Member

@RussTreadon-NOAA indicated regression tests are going well so far on Hera (#1132 (comment)). Rsyncing new Hera gsi subfolder to WCOSS2s, Orion, and Jet now. @DavidHuber-NOAA feel free to update the S4 set now.

@DavidHuber-NOAA
Copy link
Contributor

@KateFriedman-NOAA All finished on S4.

@KateFriedman-NOAA
Copy link
Member

Hera, Orion, Jet, S4 fix copies now updated with new gsi subfolder. WCOSS2 (Cactus/Dogwood) will be updated within the next few hours.

@KateFriedman-NOAA
Copy link
Member

New gsi subfolder is now in place on both WCOSS2s.

KateFriedman-NOAA pushed a commit that referenced this issue Nov 30, 2022
@aerorahul
Link staged GSI fix files instead of cloning them from gerrit (#1132)
4e3335b 
* disable cloning GSI recursively.  Link GSI fix files from central space
* add `gsi_ver` variable in fix.ver

Refs #1128
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Dec 5, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aerorahul aerorahul

@KateFriedman-NOAA KateFriedman-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link staged GSI fix files instead of cloning them from gerrit aerorahul/global-workflow
4 participants
@aerorahul @RussTreadon-NOAA @KateFriedman-NOAA @DavidHuber-NOAA