Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename monitor files to avoid name collisions. #1055

Closed
EdwardSafford-NOAA opened this issue Oct 7, 2022 · 3 comments · Fixed by #1065
Closed

Rename monitor files to avoid name collisions. #1055

EdwardSafford-NOAA opened this issue Oct 7, 2022 · 3 comments · Fixed by #1065
Assignees
Labels
bug Something isn't working

Comments

@EdwardSafford-NOAA
Copy link
Contributor

Expected behavior
Files generated by the DA monitors should not be overwritten by successive runs.

Current behavior
The rocoto default output location for the DA monitors is $NOSCRUB/monitor/*mon/stats/$suffix/gdas.$pdy. There is no hour subdirectory. Most of the files produced by the monitors include a full cycle time, so they will are unique. However the files below do not include a cycle time and are overwritten with each cycle:

OznMon:
stdout.horiz.tar.gz
stdout.time.tar.gz

RadMon:
stdout.validate.tar
radmon_angle.tar.gz
radmon_bcoef.tar.gz
radmon_bcor.tar.gz
radmon_time.tar.gz

Machines affected
All machines.

To Reproduce
Run a cycled experiment for two or more cycles. The files indicated above will be overwritten with each cycle if the rocoto default output location is used.

Detailed Description
Make these name changes to the output files:
OznMon:
stdout.horiz.tar.gz ==> stdout.horiz.$pdate.tar.gz
stdout.time.tar.gz ==> stdout.time.$pdate.tar.gz

RadMon:
stdout.validate.tar ==> stdout.validate.$pdate.tar.gz
radmon_angle.tar.gz ==> angle.$pdate.tar.gz
radmon_bcoef.tar.gz ==> bcoef.$pdate.tar.gz
radmon_bcor.tar.gz ==> bcor.$pdate.tar.gz
radmon_time.tar.gz ==> time.$pdate.tar.gz

The RadMon changes will require corresponding changes in GSI-monitor, which will be done in NOAA-EMC/GSI-Monitor#37.

@EdwardSafford-NOAA EdwardSafford-NOAA added the bug Something isn't working label Oct 7, 2022
@EdwardSafford-NOAA EdwardSafford-NOAA self-assigned this Oct 7, 2022
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/global-workflow that referenced this issue Oct 7, 2022
Initial file name changes.
@WalterKolczynski-NOAA
Copy link
Contributor

Is there a reason the path doesn't have a cycle after gdas.${PDY}? I think that would be the preferred solution.

@KateFriedman-NOAA
Copy link
Member

@RussTreadon-NOAA added $cyc subfolders into the $TANKverf_rad* paths in the GFSv16.3.0 package @ 4335ef2 . Perhaps a similar change is needed in develop?

@EdwardSafford-NOAA
Copy link
Contributor Author

OK, I'll add a $cyc subfolder instead then.

EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/global-workflow that referenced this issue Oct 11, 2022
Add $cyc to default module path, revert file name changes.
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/global-workflow that referenced this issue Oct 11, 2022
Linter changes.
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/global-workflow that referenced this issue Oct 11, 2022
Linter changes.
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/global-workflow that referenced this issue Oct 11, 2022
Linter changes.
EdwardSafford-NOAA added a commit to EdwardSafford-NOAA/global-workflow that referenced this issue Oct 11, 2022
Clean up typo.
WalterKolczynski-NOAA pushed a commit that referenced this issue Oct 12, 2022
Added a $cyc subdirectory to the default file location for monitor data in rocoto.  This ensures no file name collisions occur in the output monitor files.  This change was also recently made to GFSv16.3.0 package @ 4335ef2.

Additionally a problem with the definition of the previous cycle (m1) for the DA monitors was identified and corrected.  This corrects the MinMon's output data.

Fixes #1055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants