Skip to content

Commit

Permalink
Update UFS-DA atmospheric prep script to be consistent with GDASApp u…
Browse files Browse the repository at this point in the history
…pdate (#1265)

Updates the GDAS App version to incorporate the changes of NOAA-EMC/GDASApp#278, which restores the ability of `run_jedi_exe.py` to execute UFS-DA applications, specifically `fv3jedi_var.x`. Included in NOAA-EMC/GDASApp#278 is the removal of entry `ufsda.stage` from `ush/ufsda/__init__.py`.  Scripts which simply `import ufsda` must now specify the functions to from `ufsda.stage`. 

g-w issue #1262 documents the addition of the `ufsda.stage` line to `scripts/exgdas_global_atmos_analysis_prep.py`.  This change is required for g-w to successfully stage files used by the var and ensemble UFS-DA applications.

Fixes #1262
  • Loading branch information
RussTreadon-NOAA committed Jan 25, 2023
1 parent f98433f commit fb54bb6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Externals.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ protocol = git
required = False

[GDASApp]
hash = 843d3a9
hash = f7c23af
local_path = sorc/gdas.cd
repo_url = https://github.com/NOAA-EMC/GDASApp.git
protocol = git
Expand Down
1 change: 1 addition & 0 deletions scripts/exgdas_global_atmos_analysis_prep.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

# import UFSDA utilities
import ufsda
from ufsda.stage import atm_obs, bias_obs

# get configuration based on environment variables
config = ufsda.misc_utils.get_env_config(component='atm')
Expand Down
2 changes: 1 addition & 1 deletion sorc/checkout.sh
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ if [[ ${checkout_gsi} == "YES" ]]; then
fi

if [[ ${checkout_gdas} == "YES" ]]; then
checkout "gdas.cd" "https://github.com/NOAA-EMC/GDASApp.git" "843d3a9"; errs=$((errs + $?))
checkout "gdas.cd" "https://github.com/NOAA-EMC/GDASApp.git" "f7c23af"; errs=$((errs + $?))
fi

if [[ ${checkout_gsi} == "YES" || ${checkout_gdas} == "YES" ]]; then
Expand Down

0 comments on commit fb54bb6

Please sign in to comment.