Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire finddate.sh script usage #46

Closed
KateFriedman-NOAA opened this issue Feb 7, 2024 · 1 comment · Fixed by #47
Closed

Retire finddate.sh script usage #46

KateFriedman-NOAA opened this issue Feb 7, 2024 · 1 comment · Fixed by #47
Assignees
@KateFriedman-NOAA

Comments

@KateFriedman-NOAA
Copy link
Member

Remove reference to and usage of finddate.sh. Companion issue to NOAA-EMC/global-workflow#2279.
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Feb 7, 2024
@KateFriedman-NOAA KateFriedman-NOAA mentioned this issue Feb 7, 2024
Closed
@KateFriedman-NOAA
Copy link
Member Author

Instances of finddate.sh to remove, including the actual script:

ush/finddate.sh:# finddate.sh
ush/finddate.sh:#     list=`sh /nwprod/util/scripts/finddate.sh 19990929 s+10`
ush/finddate.sh:#     list=`sh /nwprod/util/scripts/finddate.sh 19990929 d+10`
ush/finddate.sh:#     list=`sh /nwprod/util/scripts/finddate.sh 19990929 s-10`
ush/finddate.sh:#     list=`sh /nwprod/util/scripts/finddate.sh 19990929 d-10`
ush/finddate.sh:# Copy of finddate.sh
ush/finddate.sh:function finddate() {
ush/finddate.sh:# The old finddate.sh didn't provide functions, so call the main function here
ush/finddate.sh:finddate "$1" "$2"
ush/CMakeLists.txt:  finddate.sh

Also look at:

ush/test_finddate.sh:tap_start_subtest "finddate matches old output" 4
ush/test_finddate.sh:declare +i actual="$(finddate "${start_date}" s+10)"
ush/test_finddate.sh:actual="$(finddate "${start_date}" d+10)"
ush/test_finddate.sh:actual="$(finddate "${start_date}" s-10)"
ush/test_finddate.sh:actual="$(finddate "${start_date}" d-10)"
ush/test_finddate.sh:tap_end_subtest "finddate matches old output"
ush/test_finddate.sh:tap_start_subtest "finddate extreme examples" 3
ush/test_finddate.sh:declare -i actual="10#$(finddate "${start_date}" d+366)"
ush/test_finddate.sh:actual="10#$(finddate "${start_date}" d+3653)"
ush/test_finddate.sh:actual="10#$(finddate "${start_date}" d+7305)"
ush/test_finddate.sh:tap_end_subtest "finddate extreme examples"

KateFriedman-NOAA added a commit to KateFriedman-NOAA/gfs-utils that referenced this issue Feb 7, 2024
@KateFriedman-NOAA
Retire ush/finddate.sh script
23e5f88 
Refs NOAA-EMC#46
KateFriedman-NOAA added a commit to KateFriedman-NOAA/gfs-utils that referenced this issue Feb 7, 2024
@KateFriedman-NOAA
Remove test_finddate.sh
7083092 
No longer need this script with ush/finddate.sh now gone.

Refs NOAA-EMC#46
@KateFriedman-NOAA KateFriedman-NOAA mentioned this issue Feb 7, 2024
Merged
KateFriedman-NOAA added a commit that referenced this issue Feb 7, 2024
@KateFriedman-NOAA
Retire finddate.sh and related script (#47)
7a84c88 
Removing the `ush/finddate.sh` script and its related `ush/test_finddate.sh` test script.
References to `ush/finddate.sh` have also been removed from `ush/CMakeLists.txt`.

Resolves #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KateFriedman-NOAA KateFriedman-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retire finddate.sh and related script KateFriedman-NOAA/gfs-utils
1 participant
@KateFriedman-NOAA