HR4 Gravity Wave Drag Update

[Qingfu-Liu]

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
This PR#836 depends ccpp-physics PR#207.

1. This update is a combination of the gravity wave drag (GWD) versions from the NOAA/GSL and NOAA/PSL

2. The test results with this update can be seen in:
   a) summer: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/hr3e50s
   b) winter: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/hr3d11w
   HR4GWD: same as HR3 but with the updated GWD

   Compared to the HR2 and HR3, the HR4GWD shows a significant improvement especially in 500mb height AC and CONUS precipitation forecast skills. The HR4GWD reduces the cold and dry biases in the lower troposphere compared to the HR3. It also reduces the negative wind speed biases in the troposphere compared to the HR2.

Is a change of answers expected from this PR?
Yes. Change of answers is expected

Issue(s) addressed

Gravity Wave Drag Update for HR4

Testing

How were these changes tested?
yes. see previous description

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No. Need to create new input.nml and new fix file ugwd
Have the ufs-weather-model regression test been run? On what platform?
Regression test has not been run.

• Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
• Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Tests need new input.nml file and new fix file ugwd
Do PRs in upstream repositories need to be merged first?
None

[DusanJovic-NOAA]

Please see the build error messages in the CI build, here:

https://github.com/NOAA-EMC/fv3atm/actions/runs/9142433918/job/25137982061?pr=836#step:6:2123

[Qingfu-Liu]

Please see the build error messages in the CI build, here:

https://github.com/NOAA-EMC/fv3atm/actions/runs/9142433918/job/25137982061?pr=836#step:6:2123

@DusanJovic-NOAA Thanks. I will contact Lisa to see if she can fix this problem.

[JongilHan66]

In "GFS_typedefs.F90", "use_lake2m" is defined as "logical". But in "GFS_typedefs.meta", it is defined as "integer", which should be "logical"

[JongilHan66]

I found that in ...../ccpp/physics/physics/SFC_Layer/UFS/sfc_diag.meta, "use_lake2m" was also defined as integer

[Qingfu-Liu]

Something wrong with my newly commit. Not sure why the commit upload all the files, working to fix the problem. Please postpone the review

[Qingfu-Liu]

Fixed the compile problem. This PR#836 is ready for review

[DusanJovic-NOAA]

Please list the ccpp/physics PR that this PR depends on

[Qingfu-Liu]

Please list the ccpp/physics PR that this PR depends on

@DusanJovic-NOAA Thanks. I will add it to the description section. Currently, I am still working on the compile issues from the new gravity code I was given this week. Will upload the new code after fix the compile issues

[Qingfu-Liu]

@Qingfu-Liu Once Qingfu-Liu#1 is merged, this PR should be good.

@grantfirl merged. Thank you very much

[grantfirl]

@Qingfu-Liu Could you please point the ccpp-framework to this: NCAR/ccpp-framework#549 (and update .gitmodules). This should not affect regression testing at all (it has already been tested independently on Hera).

[Qingfu-Liu]

@Qingfu-Liu Could you please point the ccpp-framework to this: NCAR/ccpp-framework#549 (and update .gitmodules). This should not affect regression testing at all (it has already been tested independently on Hera).

@grantfirl Currently, the ccpp-framework points to NCAR/ccpp-framework. Where should I change in order to make the ccpp-framework point to the NCAR/ccpp-framework#549 ? Thanks

[submodule "ccpp/framework"]
path = ccpp/framework
url = https://github.com/NCAR/ccpp-framework ==> should I change to NCAR/ccpp-framework#549 here?
branch = main

[grantfirl]

@Qingfu-Liu Could you please point the ccpp-framework to this: NCAR/ccpp-framework#549 (and update .gitmodules). This should not affect regression testing at all (it has already been tested independently on Hera).

@grantfirl Currently, the ccpp-framework points to NCAR/ccpp-framework. Where should I change in order to make the ccpp-framework point to the NCAR/ccpp-framework#549 ? Thanks

[submodule "ccpp/framework"] path = ccpp/framework url = https://github.com/NCAR/ccpp-framework ==> should I change to NCAR/ccpp-framework#549 here? branch = main

Here is how I would do it:

1. Make sure you're that you have the latest version of your HR4-GWD-update branch of fv3atm checked out.
2. cd into ccpp/framework
3. The PR branch of ccpp-framework is on the fork of peverwhee, so we need to add her fork as a remote: git add remote courtney-fork https://github.com/peverwhee/ccpp-framework
4. git fetch courtney-fork to get the branches from her fork
5. git checkout add_const_interface (this is the name of the branch that PR#549 points to)
6. Double-check that the right commit of ccpp-framework is now checked out. It should be NCAR/ccpp-framework@6e165e5.
7. cd up to the FV3 directory.
8. git add ccpp/framework
9. Edit .gitmodules as follows:
   [submodule "ccpp/framework"]
path = ccpp/framework
url = https://github.com/NCAR/ccpp-framework
branch = main
   becomes
   [submodule "ccpp/framework"]
path = ccpp/framework
#url = https://github.com/NCAR/ccpp-framework
#branch = main
url = https://github.com/peverwhee/ccpp-framework
branch = add_const_interface
10. git add .gitmodules
11. git commit -m "point to PR#549 of ccpp-framework"
12. git push

This should do it! Let me know if you run into any trouble.

[grantfirl]

@Qingfu-Liu I also noticed that in .gitmodules, for ccpp-physics, you currently are pointing to the ufs/dev branch of your fork. The branch should match the ccpp-physics PR branch: HR4-GWD-update

[Qingfu-Liu]

@Qingfu-Liu I also noticed that in .gitmodules, for ccpp-physics, you currently are pointing to the ufs/dev branch of your fork. The branch should match the ccpp-physics PR branch: HR4-GWD-update

@grantfirl Thank you very much.

[Qingfu-Liu]

@Qingfu-Liu Could you please point the ccpp-framework to this: NCAR/ccpp-framework#549 (and update .gitmodules). This should not affect regression testing at all (it has already been tested independently on Hera).

@grantfirl Currently, the ccpp-framework points to NCAR/ccpp-framework. Where should I change in order to make the ccpp-framework point to the NCAR/ccpp-framework#549 ? Thanks
[submodule "ccpp/framework"] path = ccpp/framework url = https://github.com/NCAR/ccpp-framework ==> should I change to NCAR/ccpp-framework#549 here? branch = main

Here is how I would do it:

1. Make sure you're that you have the latest version of your HR4-GWD-update branch of fv3atm checked out.
2. cd into ccpp/framework
3. The PR branch of ccpp-framework is on the fork of peverwhee, so we need to add her fork as a remote: git add remote courtney-fork https://github.com/peverwhee/ccpp-framework
4. git fetch courtney-fork to get the branches from her fork
5. git checkout add_const_interface (this is the name of the branch that PR#549 points to)
6. Double-check that the right commit of ccpp-framework is now checked out. It should be NCAR/ccpp-framework@6e165e5.
7. cd up to the FV3 directory.
8. git add ccpp/framework
9. Edit .gitmodules as follows:
   [submodule "ccpp/framework"]
path = ccpp/framework
url = https://github.com/NCAR/ccpp-framework
branch = main
   becomes
   [submodule "ccpp/framework"]
path = ccpp/framework
#url = https://github.com/NCAR/ccpp-framework
#branch = main
url = https://github.com/peverwhee/ccpp-framework
branch = add_const_interface
10. git add .gitmodules
11. git commit -m "point to PR#549 of ccpp-framework"
12. git push

This should do it! Let me know if you run into any trouble.

@grantfirl Thank you very much for the help. I just changed the pointer of the ccpp/framework to NCAR/ccpp-framework#549

[Qingfu-Liu]

The changes of the NoahMP model (which are not used for HR4-GWD-update tests) have been retracted. All the regression tests are passed on Hera