Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aux2d dim #833

Closed
wants to merge 18 commits into from
Closed

Conversation

drnimbusrain
Copy link

@drnimbusrain drnimbusrain commented May 13, 2024

Description

There is a bug in dimension definition for the 2D auxiliary array.

This can only be identified if a user only wants to output 2D auxilarly arrays, and will face CCPP prebuild errors that clearly show the inconsistency.

    raise Exception('Dimension {}, required by variable {}, not defined in host model metadata'.format(
Exception: Dimension number_of_3d_auxiliary_arrays, required by variable auxiliary_2d_arrays, not defined in host model metadata

This bug also exists in the CCPP auxiliary ReadTheDocs:

https://ccpp-techdoc.readthedocs.io/en/latest/ParamSpecificOutput.html#output-of-auxiliary-arrays-from-ccpp
image

Issue(s) addressed

#834

Testing

How were these changes tested?
RDHPCs Hera.
No changes to baseline and regression tests not performed.

@DusanJovic-NOAA
Copy link
Collaborator

I do not see corresponding ufs-weather-model PR.

@drnimbusrain
Copy link
Author

I do not see corresponding ufs-weather-model PR.

@DusanJovic-NOAA Where in the ufs-weather-model are corresponding changes needed for this bug fix? This is only a change for bugfix to fv3atm/ccpp/data/GFS_typedefs.meta.

@DusanJovic-NOAA
Copy link
Collaborator

The ufs-weather-model PR is required to run regression tests. Or, if you want I can merge this change into one of my PRs.

@drnimbusrain
Copy link
Author

drnimbusrain commented Jul 8, 2024 via email

@DusanJovic-NOAA
Copy link
Collaborator

Ah, just updating the FV3 submodule hash in ufs-weather-model. Yes, could you just merge it? Thanks!

Merged with #856

@DusanJovic-NOAA
Copy link
Collaborator

Merged via #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants