-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aux2d dim #833
Fix aux2d dim #833
Conversation
I do not see corresponding ufs-weather-model PR. |
@DusanJovic-NOAA Where in the ufs-weather-model are corresponding changes needed for this bug fix? This is only a change for bugfix to fv3atm/ccpp/data/GFS_typedefs.meta. |
The ufs-weather-model PR is required to run regression tests. Or, if you want I can merge this change into one of my PRs. |
Ah, just updating the FV3 submodule hash in ufs-weather-model.
Yes, could you just merge it? Thanks!
…On Mon, Jul 8, 2024, 1:05 PM Dusan Jovic ***@***.***> wrote:
The ufs-weather-model PR is required to run regression tests. Or, if you
want I can merge this change into one of my PRs.
—
Reply to this email directly, view it on GitHub
<#833 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNTBS2OHX46NQ7E5VW3ZLLBFFAVCNFSM6AAAAABHUS63HCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUG4ZDGMRZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Merged with #856 |
Merged via #856 |
Description
There is a bug in dimension definition for the 2D auxiliary array.
This can only be identified if a user only wants to output 2D auxilarly arrays, and will face CCPP prebuild errors that clearly show the inconsistency.
This bug also exists in the CCPP auxiliary ReadTheDocs:
https://ccpp-techdoc.readthedocs.io/en/latest/ParamSpecificOutput.html#output-of-auxiliary-arrays-from-ccpp
Issue(s) addressed
#834
Testing
How were these changes tested?
RDHPCs Hera.
No changes to baseline and regression tests not performed.