Updates of ccpp-framework and ccpp-physics (merge ccpp-framework feature/capgen into main/20240308) #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review and testing
…ashes min-1' and update long name to make clear this is per 5 minutes
This was referenced Mar 8, 2024
…es per minute to flashes per 5 minutes to match diagnostic units
…ture/ccpp_framework_merge_feature_capgen_into_main_20240308
DusanJovic-NOAA
approved these changes
Mar 11, 2024
|
@climbfuji ufs-community/ccpp-physics#182 and the ccpp-framework PRs are merged, so this is ready for the submodule and .gitmodules update. |
|
@grantfirl Done. |
|
@jkbk2004 this PR is ready for final review. |
jkbk2004
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the submodule pointers for ccpp-framework and ccpp-physics for the changes described in the associated PRs below. Note that this is not yet switching to
capgen, but it's a requirement for the transition further down the road.One change is necessary in
GFS_typedefs.meta: change unitsflashes 5 min-1toflashes min-1. See NCAR/ccpp-physics#1047 for a discussion of this change.Issue(s) addressed
n/a
Testing
See ufs-community/ufs-weather-model#2181
Dependencies