Update upp submodule for fixing in-line post issues for RRFS and HAFS #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
13 tasks
|
@DusanJovic-NOAA @HuiyaChuang-NOAA Regression tests are done. we can start merging in this pr. can you leave any comments and move on for approval? |
DusanJovic-NOAA
approved these changes
Jul 15, 2022
|
@WenMeng-NOAA sounds like we can clean up change conversations. can you click the resolved button? so that we can move on. |
Done. Thanks! @jkbk2004 |
junwang-noaa
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to update the upp submodule to fix in-line post issues for RRFS and HAFS:
Extreme ABSV in RRFS 3-km North America grid
In-consistent dx/dy in grid2 metadata with model output when HAFS domain crossing the prime meridian
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes. The baseline for RRFS and HAFS will be changed due to the fixes.
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first? No