-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support implementation of TVD methods in PBL and cumulus convective schemes #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
large scale rain, and convective rain at the end of each coupling step if coupling with chemistry model.
defining zero and one.
in noah/osu land-surface model subdriver.
band layer cloud optical depths (0.55 and 10 mu channels) to prevent floating invalid errors due to uninitialized optical depth arrays.
coupling array at the beginning of each coupling step if coupled with chemistry model.
the NUOPC Realize phase since it breaks coupling with aerosol component.
This reverts commit 735eb9e.
in vertically-diffused tracer array. Ensure interstitial tracer indexes are properly set for specific microphysics schemes.
14 tasks
DusanJovic-NOAA
approved these changes
Nov 9, 2021
junwang-noaa
approved these changes
Nov 9, 2021
climbfuji
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements changes supporting TVD methods for PBL and cumulus convective parameterizations introduced by ccpp/physics PR #754 (Jongil Han, NOAA/EMC).
Specifically, a new rainwater tracer index (
ntrwx
) for the PBL vertically-diffused tracer array is added to the CCPP interstitial datatype, and all vertically-diffused tracer indices are properly set according to the selected microphysics scheme.Issue(s) addressed
Testing
These changes were tested on Hera/Intel and Orion/Intel platforms.
Preliminary regression tests were run on Hera/Intel. NOTE: This PR changes the regression test baseline.
Dependencies