Remove zorl interstitial variables, remove/replace references to IPD in comments in atmos_model.F90, rename Sfcprop%zorlw to Sfcprop%zorlwav #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove_zorl_interstitial
…ove_zorl_interstitial
climbfuji
changed the title
climbfuji
force-pushed
the
remove_zorl_interstitial
branch
from
9e16dd6 to
1613a3a
Compare
…ove_zorl_interstitial
This was referenced Apr 5, 2021
climbfuji
requested review from
SMoorthi-emc,
junwang-noaa,
DusanJovic-NOAA,
ShanSunNOAA and
DeniseWorthen
ShanSunNOAA
approved these changes
Apr 5, 2021
climbfuji
changed the title
This was referenced Apr 9, 2021
junwang-noaa
pushed a commit
that referenced
this pull request
Apr 15, 2021
…2 threading (#279) * changed .gitmodules to point to merra2 ccpp/physics * remove GFDL_atmos_cubed_sphere and ccpp-framework from .git module * remove IPD gfsphysics * Update .gitmodules and submodule pointer for ccpp-physics for code review and testing * Remove interstitial zorl composites * Update .gitmodules and submodule pointer fpor ccpp-physics for code review and testing * Remove or replace references to IPD in comments in atmos_model.F90 * Initialize Sfcprop%zorlx to clear_val instead of huge * Update submodule pointer for ccpp-physics * Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water * Rename Sfcprop%zorlw to Sfcprop%zorlwav * Rename Sfcprop%zorlo to Sfcprop%zorlw * update submodule pointer for ccpp-physics * Revert change to .gitmodules and update submodule pointer for ccpp-physics Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
|
Merged as part of #279, doesn't get flagged as merged automatically because we are doing squashed merges in fv3atm. |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Jun 13, 2022
* If ufs.cpld.cpl.r.* files do not reproduce, try nccmp * Modify/add to run cpld 35d bmark tests * Fix nccmp implementation. Fix a bug for 35d tests * Use env var NCCMP * Add hera.intel to rt_35 and rt_wave_35d * Use which to find nccmp path. Apply nccmp to all files that fail cmp. Fix a bug in fv3_ccpp_wrtGauss_netcdf_parallel * Change compare method from nccmp to compare_ncfile.py * Netcdf compare changes on Hera; skip-ci * Netcdf compare changes on WCOSS Dell P3; skip-ci * Modify comopare_ncfile.py * Netcdf compare changes on wcoss cray * Implement Dusan's ecflow fix NOAA-EMC#273 * Move miniconda3 to emc.nemspara on Hera and Orion. Minor change in default_vars.sh
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/fv3atm
that referenced
this pull request
Nov 17, 2023
* Bringing over internal updates to nh_core and nh_utils which includes a revision to the semi-implicit solver to linearize vertical sound wave propagation about the hydrostatic state. * resolve inconsistent use of single and double precision in rayleigh damping. Address spacing change. * rename tau_w * Modify the rff calculation to be fully double precision. Fixed a mistake in the previous cherry-pick commit * fully implement the name change of tau_w to fast_tau_w_sec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the zorl (surface roughness length) interstitial variables and uses the persistent variables instead. This reduces memory footprint and computational overhead. For further details, see NCAR/ccpp-physics#596.
Also included:
atmos_model.F90to remove/replace references to IPD.Sfcprop%zorlwtoSfcprop%zorlwavto prepare for a follow-up change ofSfcprop%zorlotoSfcprop%zorlwTesting
For regression testing, see ufs-community/ufs-weather-model#479.
Dependencies
NCAR/ccpp-physics#596
#261
ufs-community/ufs-weather-model#479