Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grib2 table files with the new release g2tmpl #880

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update grib2 table files with the new release g2tmpl #880

merged 1 commit into from
Mar 6, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

Update the grib2 table files with the new release g2tmpl.

AndrewBenjamin-NOAA
AndrewBenjamin-NOAA approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@AndrewBenjamin-NOAA AndrewBenjamin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenMeng-NOAA these all look fine.

AndrewBenjamin-NOAA
AndrewBenjamin-NOAA approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@AndrewBenjamin-NOAA AndrewBenjamin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenMeng-NOAA These all look good to me

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. For your reference, my test results on Hera are at

[Wen.Meng@hfe04 ~/stmp2]$ pwd
/scratch1/NCEPDEV/stmp2/Wen.Meng
[Wen.Meng@hfe04 ~/stmp2]$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:14 post_nmmb_meso_2014120818_Grib2_pe_test/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Mar  6 14:14 rap_2020072316/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:14 post_nmmb_meso_2014120818_Grib2/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Mar  6 14:14 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2_pe_test/BGRD3D03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 hrrr_2020060118/WRFTWO.GrbF04.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2/BGRD3D03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2_pe_test/BGRDSF03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2/BGRDSF03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp  1951 Mar  6 14:16 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  1951 Mar  6 14:16 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14748 Mar  6 14:16 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14748 Mar  6 14:16 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14594 Mar  6 14:18 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2516 Mar  6 14:18 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2516 Mar  6 14:18 rtma_2023040400/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14594 Mar  6 14:19 fv3r_2023062800_pe_test/NATLEV10.tm00.diff

There should be changes in field values and variable names. The grib2 table update might impact on grib2 metadata part.

@WenMeng-NOAA WenMeng-NOAA added the enhancement New feature or request label Mar 6, 2024
@WenMeng-NOAA WenMeng-NOAA linked an issue Mar 6, 2024 that may be closed by this pull request
Update UPP with the new release g2tmpl #879
Closed
@WenMeng-NOAA WenMeng-NOAA added Baseline Change The baselines of the UPP regression tests are changed. RRFS Ready for Review This PR is ready for code review. labels Mar 6, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2. The baselines for nmmb, rap, hrrr, fv3r and 3drtma will be recreated with this PR.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. For your reference, my test results on Hera are at

[Wen.Meng@hfe04 ~/stmp2]$ pwd
/scratch1/NCEPDEV/stmp2/Wen.Meng
[Wen.Meng@hfe04 ~/stmp2]$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:14 post_nmmb_meso_2014120818_Grib2_pe_test/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Mar  6 14:14 rap_2020072316/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:14 post_nmmb_meso_2014120818_Grib2/BGDAWP03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp    75 Mar  6 14:14 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2_pe_test/BGRD3D03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 hrrr_2020060118/WRFTWO.GrbF04.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2/BGRD3D03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 hrrr_2020060118_pe_test/WRFTWO.GrbF04.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2_pe_test/BGRDSF03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp     0 Mar  6 14:15 post_nmmb_meso_2014120818_Grib2/BGRDSF03.tm00.Grib2.diff
-rw-r--r-- 1 Wen.Meng stmp  1951 Mar  6 14:16 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  1951 Mar  6 14:16 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14748 Mar  6 14:16 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14748 Mar  6 14:16 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14594 Mar  6 14:18 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2516 Mar  6 14:18 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  2516 Mar  6 14:18 rtma_2023040400/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 14594 Mar  6 14:19 fv3r_2023062800_pe_test/NATLEV10.tm00.diff

There should be changes in field values and variable names. The grib2 table update might impact on grib2 metadata part.

RTs have completed on Hera, Hercules, and Orion. Changes match with your results

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 0d438f4 into NOAA-EMC:develop Mar 6, 2024
5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Mar 6, 2024
Closed
@EricSinsky-NOAA EricSinsky-NOAA mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@AndrewBenjamin-NOAA AndrewBenjamin-NOAA AndrewBenjamin-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Change The baselines of the UPP regression tests are changed. enhancement New feature or request Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update UPP with the new release g2tmpl
3 participants
@WenMeng-NOAA @FernandoAndrade-NOAA @AndrewBenjamin-NOAA