Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github links #605

Merged
merged 2 commits into from
Dec 15, 2022
Merged

github links #605

merged 2 commits into from
Dec 15, 2022

Conversation

camshe
Copy link
Contributor

@camshe camshe commented Dec 14, 2022

Issue #596

@camshe camshe added the documentation Improvements or additions to documentation label Dec 14, 2022
@camshe camshe requested a review from WenMeng-NOAA December 14, 2022 21:34
@WenMeng-NOAA WenMeng-NOAA linked an issue Dec 14, 2022 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Dec 14, 2022
docs/AddNewVariable.rst Outdated Show resolved Hide resolved
@fossell
Copy link
Contributor

fossell commented Dec 15, 2022

@camshe - it looks like the CI github action tests were successful on your fork this time, glad that was resolved. Please address Tracy's comment/suggestion and push that mod to your branch and then I'll take another look and approve.

@hertneky - Do you think we should look at the RTDs rendering of this mod too?

@fossell
Copy link
Contributor

fossell commented Dec 15, 2022

@hertneky - Ack, nevermind, I just saw the RTDs link in the issue and looked at the mods and tested the link. Seems good.

@fossell
Copy link
Contributor

fossell commented Dec 15, 2022

@camshe - I'm not able to see the Add A Variable page on your RTDs of the update-ug-github anymore. I can see all other pages, e.g. Code Overview, but I can't navigate to Add a Variable. Was there an issue with the RTDs build after your recent push?
@hertneky - Are you able to see it? Am I missing something?

@hertneky
Copy link
Contributor

@fossell I see it. And the link you provided works as well. Maybe try a refresh.

@camshe
Copy link
Contributor Author

camshe commented Dec 15, 2022

@camshe - I'm not able to see the Add A Variable page on your RTDs of the update-ug-github anymore. I can see all other pages, e.g. Code Overview, but I can't navigate to Add a Variable. Was there an issue with the RTDs build after your recent push? @hertneky - Are you able to see it? Am I missing something?

Yeah I didn't see the newest update either until I refreshed, even after building again. Should be good to go now

@fossell
Copy link
Contributor

fossell commented Dec 15, 2022

@hertneky - Ok it finally updated for me too. Sorry about that!

@fossell
Copy link
Contributor

fossell commented Dec 15, 2022

@WenMeng-NOAA - These changes look good on our end. Let Cam know how/when to proceed. thanks!

@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2. No baseline changes were found.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Dec 15, 2022
@WenMeng-NOAA WenMeng-NOAA merged commit 7a8cfc3 into NOAA-EMC:develop Dec 15, 2022
@camshe camshe deleted the update-ug-github branch December 16, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the read the docs user guide with GitHub Discussions link
4 participants