-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github links #605
github links #605
Conversation
@camshe - it looks like the CI github action tests were successful on your fork this time, glad that was resolved. Please address Tracy's comment/suggestion and push that mod to your branch and then I'll take another look and approve. @hertneky - Do you think we should look at the RTDs rendering of this mod too? |
@hertneky - Ack, nevermind, I just saw the RTDs link in the issue and looked at the mods and tested the link. Seems good. |
@camshe - I'm not able to see the Add A Variable page on your RTDs of the update-ug-github anymore. I can see all other pages, e.g. Code Overview, but I can't navigate to Add a Variable. Was there an issue with the RTDs build after your recent push? |
@fossell I see it. And the link you provided works as well. Maybe try a refresh. |
Yeah I didn't see the newest update either until I refreshed, even after building again. Should be good to go now |
@hertneky - Ok it finally updated for me too. Sorry about that! |
@WenMeng-NOAA - These changes look good on our end. Let Cam know how/when to proceed. thanks! |
The UPP RT tests were completed on WCOSS2. No baseline changes were found. |
Issue #596