Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates for RRFS snow variables #601

Merged
merged 6 commits into from
Dec 19, 2022
Merged

Small updates for RRFS snow variables #601

merged 6 commits into from
Dec 19, 2022

Conversation

EricJames-NOAA
Copy link
Contributor

This PR turns on the variable density snow accumulation variable. The PR also corrects the GRIB2 encoding for run total snowfall accumulation for both WEASD and variable density snow accumulation; these were incorrectly encoded as 1-h accumulations.

The code produces bitwise identical results for all regression tests. It has been tested for RRFS_CONUS_3km system (RRFS_B) on Jet.

@WenMeng-NOAA WenMeng-NOAA linked an issue Dec 14, 2022 that may be closed by this pull request
Small changes related to frozen precip variables in RRFS #592
Closed
@WenMeng-NOAA WenMeng-NOAA linked an issue Dec 16, 2022 that may be closed by this pull request
Correct GRIB2 labeling for MAXUVV / MAXDVV used in RRFS. #598
Closed
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Will you combine the changes for the issue #598 in this PR or a separate PR? Thanks!

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Will you combine the changes for the issue #598 in this PR or a separate PR? Thanks!

@WenMeng-NOAA good idea to combine these changes. I will update my branch shortly.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Your PR will be the next one to be processed. Can you sync your branch with upstream/develop? Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA My UPP test with the RRFS model history files provided by you is at
/scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713
Please verify and let me know if it is consistent with your test. Thanks!

MatthewPyle-NOAA
MatthewPyle-NOAA reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good from my perspective (focusing more on the MAXUVV/MAXDVV labeling issue).

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA My UPP test with the RRFS model history files provided by you is at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713 Please verify and let me know if it is consistent with your test. Thanks!

@WenMeng-NOAA your results look consistent with my test! Thanks!

@WenMeng-NOAA WenMeng-NOAA added No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Dec 19, 2022
@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. No baseline update is needed with this PR.

@WenMeng-NOAA WenMeng-NOAA merged commit 5dd804d into NOAA-EMC:develop Dec 19, 2022
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewPyle-NOAA MatthewPyle-NOAA MatthewPyle-NOAA left review comments

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

Assignees
No one assigned
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
3 participants
@EricJames-NOAA @WenMeng-NOAA @MatthewPyle-NOAA