Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 1000 mb HGT corrupted at RRFS 3KM parallel run. #396

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

WenMeng-NOAA
Copy link
Collaborator

Add fixes for 1000 mb HGT corrupted at RRFS 3KM parallel run.

Copy link
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

sorc/ncep_post.fd/MDL2P.f Outdated Show resolved Hide resolved
Copy link

@EricRogers-NOAA EricRogers-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@WenMeng-NOAA WenMeng-NOAA linked an issue Sep 28, 2021 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. The baseline for hafs is needed to be recreated with this PR merging.

@WenMeng-NOAA WenMeng-NOAA added bug Something isn't working Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Sep 29, 2021
@WenMeng-NOAA WenMeng-NOAA merged commit 14171cd into NOAA-EMC:develop Sep 29, 2021
@WenMeng-NOAA WenMeng-NOAA deleted the post_1000hgt branch January 10, 2022 17:25
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
…predefined grids (NOAA-EMC#396)

## DESCRIPTION OF CHANGES:
* When using a predefined grid, allow the default values of DT_ATMOS, LAYOUT_X, LAYOUT_Y, and BLOCKSIZE for that grid to be overwritten with values specified by the user in the experiment configuration file.
* Add a WE2E test (config.grid_RRFS_CONUS_25km_modify_DT_ATMOS_LAYOUT_XY_BLOCKSIZE.sh) that uses the RRFS_CONUS_25km predefined grid but changes DT_ATMOS, LAYOUT_X, LAYOUT_Y, and BLOCKSIZE from the default values for that grid.
* Update comments.

## TESTS CONDUCTED:
* Ran the new WE2E test (grid_RRFS_CONUS_25km_modify_DT_ATMOS_LAYOUT_XY_BLOCKSIZE) on Hera.  It was successful.
EricJames-NOAA added a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
* Adding CRTMv2.4 for simulated GOES-18 brightness temperatures from RRFS.

* Enabling use of a separate CRTM fix directory for UPP.

* Introducing use of FIX_UPP_CRTM for new version of CRTM.

* Updating static files for output simulated GOES ABI brightness temps.

* Reverting static files to be consistent with changes to UPP PR.

* Making postxconfig-NT.txt consistent with UPP PR.

* Making static files consistent with those used in realtime RRFS-B

* Updating fix files to output new SBTA fields in NATLEV instead of PRSLEV files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. bug Something isn't working HAFS Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1000 mb heights for the North American RRFS domain is corrupted
3 participants