Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict undefined grids from UPP computation Part 3 #348

Merged
merged 14 commits into from
Aug 23, 2021
Merged

Restrict undefined grids from UPP computation Part 3 #348

merged 14 commits into from
Aug 23, 2021

Conversation

WenMeng-NOAA
Copy link
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Jul 16, 2021 •
edited
Loading

The main changes are:

  • Modify boundary layer computation BNDLYR.f which causes ufs-weather-model global inline post debug mode failure.
  • Enhancement of undefined grids involved UPP computation which cause regional inline post debug mode failure.
  • Remove the legacy sigma level temperature from RRFS products.
  • Solve the extreme values in MCONV issue of RRFS products with output domain larger than computation domain.
  • Increase VERSION to 10.0.9.

@WenMeng-NOAA WenMeng-NOAA linked an issue Jul 16, 2021 that may be closed by this pull request
Runtime error when running a regression test in debug mode #347
Closed
@WenMeng-NOAA WenMeng-NOAA changed the title Modify boundary layer computation Restrict undefined grids from UPP computation Part 3 Aug 5, 2021
HuiyaChuang-NOAA
HuiyaChuang-NOAA reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, let me know what you think

sorc/ncep_post.fd/CLDRAD.f Show resolved Hide resolved
sorc/ncep_post.fd/FRZLVL2.f Outdated Show resolved Hide resolved
sorc/ncep_post.fd/MIXLEN.f
@@ -124,6 +136,7 @@ SUBROUTINE MIXLEN(EL0,EL)
!$omp parallel do private(i,j,elst,elvgd,ensq,q2kl,ziag)
DO J=JSTA_M,JEND_M
DO I=2,IM-1
IF(T(I,J,L)<spval)THEN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you add PMID

sorc/ncep_post.fd/WETBULB.f Show resolved Hide resolved
@WenMeng-NOAA
Copy link
Collaborator Author

The ufs-weather-model tests for global inline post, global inline post in debug mode, regional inline post and regional inline post in debug mode were conducted on WCOSS-Dell and Hera. All tests can be successfully run though.

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. With the PR merged, the baselines for
hafs, fv3r will be recreated.

@HuiyaChuang-NOAA
Copy link
Contributor

The ufs-weather-model tests for global inline post, global inline post in debug mode, regional inline post and regional inline post in debug mode were conducted on WCOSS-Dell and Hera. All tests can be successfully run though.

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. With the PR merged, the baselines for
hafs, fv3r will be recreated.

Great news! Thank you for your effort.

@WenMeng-NOAA WenMeng-NOAA merged commit a49af05 into NOAA-EMC:develop Aug 23, 2021
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 23, 2021
Closed
@WenMeng-NOAA WenMeng-NOAA deleted the post_bndlyr branch March 2, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa left review comments

@EricRogers-NOAA EricRogers-NOAA EricRogers-NOAA approved these changes

@HuiyaChuang-NOAA HuiyaChuang-NOAA HuiyaChuang-NOAA approved these changes

@DusanJovic-NOAA DusanJovic-NOAA Awaiting requested review from DusanJovic-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error when running a regression test in debug mode
4 participants
@WenMeng-NOAA @HuiyaChuang-NOAA @junwang-noaa @EricRogers-NOAA