Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for MPAS applications #1037

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

EricJames-NOAA
Copy link
Contributor

Based on realtime testing with MPASSIT and UPP for a 1-km MPAS domain, we need to add some checks for SPVAL in INITPOST_MPAS.

The log prints regarding "ABNORMAL 2MT" is also commented out to save space, because 0-h MPAS output does not have 2-m temperature (it is all zeroes).

This PR also includes some control file updates associated with Jaymes Kenyon's recent PR.

Testing was carried out for a realtime 1-km MPAS case on Hera.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Do you have an UPP issue linked to this PR?

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Do you have an UPP issue linked to this PR?

I just created an issue...sorry about that.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Can you sync your branch with latest UPP develop branch for reviewing and testing?

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Sep 9, 2024
@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Can you sync your branch with latest UPP develop branch for reviewing and testing?

@WenMeng-NOAA I synced it. Thanks.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Do you have 1-km MPAS model output for my UPP standalone test?

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA My test with MPAS 3-km model output is at /home/Wen.Meng/stmp2/mpas_2024082112 on Hera. Please validate and let me know if you see issues.

Copy link
Contributor

@jaymes-kenyon jaymes-kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenMeng-NOAA — These changes look good to me! Thanks, @EricJames-NOAA!

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA Do you have 1-km MPAS model output for my UPP standalone test?

@WenMeng-NOAA I have test 1-km MPAS / MPASSIT output here on Hera:

/scratch2/BMC/wrfruc/ejames/rrfs2/stmp/fire/1.0.1/rrfs.20240826/00/mpassit/00_00/MPAS-A_out.2024-08-26_00.00.00.nc

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA Do you have 1-km MPAS model output for my UPP standalone test?

@WenMeng-NOAA I have test 1-km MPAS / MPASSIT output here on Hera:

/scratch2/BMC/wrfruc/ejames/rrfs2/stmp/fire/1.0.1/rrfs.20240826/00/mpassit/00_00/MPAS-A_out.2024-08-26_00.00.00.nc

@EricJames-NOAA Please validate my test with MPAS 1-km output at /home/Wen.Meng/stmp2/mpas_2024082600.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on R&D machines. There should be no baseline update with this PR.

@WenMeng-NOAA
Copy link
Collaborator

The UPP Rts have been completed on WCOSS2, without baseline change.

Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes across Hera, Hercules, and Orion RTs.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit d581f05 into NOAA-EMC:develop Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPAS Ready for commit queue Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifications for running UPP on MPASSIT output which contains gridpoints with missing values
4 participants