Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable output of VEGMIN/VEGMAX #1021

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

EricJames-NOAA
Copy link
Contributor

Initializing MPAS off the FV3 RRFS requires output of VEGMAX and VEGMIN, which are the seasonal max/min green vegetation fraction. This enables us to initialize the realtime greenness vegetation fraction from RRFS in MPAS.

The code was tested for the RRFS 3km North America system on Hera, with no change to any output except the addition of these two new fields in NATLEV file.

@WenMeng-NOAA WenMeng-NOAA linked an issue Aug 20, 2024 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Aug 21, 2024
@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA I conducted the UPP standalone test for RRFS with RRFS NA model output and saw two new fields in dataset NATLEV as:

Wen.Meng@hfe06 rrfs_2022022412-after$ wgrib2 NATLEV10.tm00 -match VEGM
1433:7525413030:d=2022022412:VEGMIN:surface:10 hour fcst:
1434:7529670117:d=2022022412:VEGMAX:surface:10 hour fcst:

You may access my test at /home/Wen.Meng/stmp2/rrfs_2022022412-after on Hera. Please validate and let me know if you see any issues.

@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on R&D machines. This PR will have baseline recreation for fv3r and 3drtma tests. For your reference, my testing is at /home/Wen.Meng/stmp2/UPP-RTs on Hera:

Wen.Meng@hfe06 UPP-RTs$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp    75 Aug 21 01:10 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp 26701 Aug 21 01:12 rtma_2023040400_pe_test/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 26701 Aug 21 01:13 rtma_2023040400/NATLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 26434 Aug 21 01:13 fv3r_2023062800/NATLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 26434 Aug 21 01:13 fv3r_2023062800_pe_test/NATLEV10.tm00.diff

@WenMeng-NOAA WenMeng-NOAA removed the request for review from FernandoAndrade-NOAA August 21, 2024 14:03
@WenMeng-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA This PR has been aimed at the "release/rrfs_v1" branch. There is no need for the UPP RTs. Sorry for the misleading comments.

@EricJames-NOAA
Copy link
Contributor Author

@EricJames-NOAA I conducted the UPP standalone test for RRFS with RRFS NA model output and saw two new fields in dataset NATLEV as:

Wen.Meng@hfe06 rrfs_2022022412-after$ wgrib2 NATLEV10.tm00 -match VEGM
1433:7525413030:d=2022022412:VEGMIN:surface:10 hour fcst:
1434:7529670117:d=2022022412:VEGMAX:surface:10 hour fcst:

You may access my test at /home/Wen.Meng/stmp2/rrfs_2022022412-after on Hera. Please validate and let me know if you see any issues.

@WenMeng-NOAA your results look consistent with mine! Thanks for the test.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA I conducted the UPP standalone test for RRFS with RRFS NA model output and saw two new fields in dataset NATLEV as:

Wen.Meng@hfe06 rrfs_2022022412-after$ wgrib2 NATLEV10.tm00 -match VEGM
1433:7525413030:d=2022022412:VEGMIN:surface:10 hour fcst:
1434:7529670117:d=2022022412:VEGMAX:surface:10 hour fcst:

You may access my test at /home/Wen.Meng/stmp2/rrfs_2022022412-after on Hera. Please validate and let me know if you see any issues.

@WenMeng-NOAA your results look consistent with mine! Thanks for the test.

@EricJames-NOAA Thanks for confirmation.

@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 897fcb0 into NOAA-EMC:release/rrfs_v1 Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VEGMIN/VEGMAX needed for MPAS initialization from RRFS
2 participants