Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The executable directory needs to be switchable to exec #447

Closed
chan-hoo opened this issue Feb 20, 2022 · 7 comments · Fixed by #448
Closed

The executable directory needs to be switchable to exec #447

chan-hoo opened this issue Feb 20, 2022 · 7 comments · Fixed by #448

Comments

@chan-hoo
Copy link
Contributor

The current directory for the executable 'upp.x' is 'bin'. However, we need an option for 'exec' to meet the NCO standards.

@WenMeng-NOAA
Copy link
Collaborator

@chan-hoo Are you building the upp executable "upp.x" on WCOSS1/WCOSS2 for NCEP implementation development?

@chan-hoo
Copy link
Contributor Author

@WenMeng-NOAA, I am updating the UFS SRW App to meet the NCO standards. UPP is one of the external components. Since the external components are built within the integrated cmake system in the UFS SRW App, the directory where upp.x is created should be named to 'exec' from UPP. I've submitted a PR for this (#448). Is there any other way for this?

@kgerheiser
Copy link
Contributor

kgerheiser commented Feb 21, 2022

How about doing it like UFS_UTILS?

https://github.com/ufs-community/UFS_UTILS/blob/570ea3966c125ead7e90b4342be2efc22a8b1f41/CMakeLists.txt#L77-L80

Edit: Saw your PR, and that looks good.

@WenMeng-NOAA
Copy link
Collaborator

@chan-hoo We have build script under tests/compile_upp.sh which generates executable upp.x under exec/ on WCOSS1/WCOSS2, Hera, Orion, Jet, s4. Do you think UFS SRW app could use it?

@WenMeng-NOAA
Copy link
Collaborator

WenMeng-NOAA commented Feb 21, 2022

@chan-hoo The build script tests/compile_upp.sh is currently used by GFS, HAFS, 3DRTMA implementation development. Your PR #448 might have impact on them.

@chan-hoo
Copy link
Contributor Author

chan-hoo commented Feb 22, 2022

@WenMeng-NOAA, My PR #448 should not affect the build script (compile_upp.sh) at all. You don't have to worry about it. The new optional argument -DEMC_EXEC_DIR=ON is necessary only when a user wants to create upp.x in the exec directory directly. For the bin directory, the build commands are the same as before. Apart from the others you listed, UFS SRW App does not use the component's own build scripts such as compile_upp.sh when it builds executables. Instead, it uses its own cmake configuration that integrates all the components into one. Therefore, the PR #448 is a must for that.

@WenMeng-NOAA
Copy link
Collaborator

@chan-hoo Got it. Thanks for clarification.

@WenMeng-NOAA WenMeng-NOAA linked a pull request Feb 23, 2022 that will close this issue
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
* Update scripts for running ensemble retros on Hera.

* changes for running RRFSE retro

* Update retro data path on Jet

* Use spinup cycles for ensemble initialization

* Update JREGIONAL_RUN_FCST

* Update JREGIONAL_RUN_PREPSTART

* Update JREGIONAL_SAVE_RESTART

* Updating config.sh for CONUS_13km

* Update model_configure to have different output frequency

* Updating config.sh for CONUS_3km

Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov>
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
* Update scripts for running ensemble retros on Hera.

* changes for running RRFSE retro

* Update retro data path on Jet

* Use spinup cycles for ensemble initialization

* Update JREGIONAL_RUN_FCST

* Update JREGIONAL_RUN_PREPSTART

* Update JREGIONAL_SAVE_RESTART

* Updating config.sh for CONUS_13km

* Update model_configure to have different output frequency

* Updating config.sh for CONUS_3km

Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov>

Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants