Feature/obs error assignment tool #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OAA-EMC/PyGSI into feature/obsErrorAssignmentTool
…OAA-EMC/PyGSI into feature/obsErrorAssignmentTool
…OAA-EMC/PyGSI into feature/obsErrorAssignmentTool
…OAA-EMC/PyGSI into feature/obsErrorAssignmentTool
|
|
||
| # specify the path to the input diag files | ||
|
|
||
| config_path=/scratch1/NCEPDEV/stmp4/Azadeh.Gholoubi/GDAS-ops/PyGSI/ush/obsErrorAssignmentTool/config_files/ |
There was a problem hiding this comment.
I would make this more generic. Maybe just: /PyGSI/ush/obsErrorAssignmentTool/config_files/
| qc_flag=0 | ||
|
|
||
| # specify the path to saving output plots and csv file | ||
| output=/scratch1/NCEPDEV/stmp4/Azadeh.Gholoubi/GDAS-ops/PyGSI/ush/obsErrorAssignmentTool/output/$bindir/ |
There was a problem hiding this comment.
Same comment as above.
| if [ $machine = orion ]; then | ||
| PyGSI=${PyGSI:-/Path/to/PyGSI/} # Change this to your own branch | ||
| elif [ $machine = hera ]; then | ||
| PyGSI=${PyGSI:-/scratch1/NCEPDEV/stmp4/Azadeh.Gholoubi/GDAS-ops/PyGSI/} # Change this to your own branch |
There was a problem hiding this comment.
Same as above. Rather than your specific path, just more generic.
| @@ -0,0 +1,452 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Overall, looks great. Do you mind adding a short docstring in each function so future users know what the function is doing?
|
@kevindougherty-noaa , Thank you for your comments Kevin. I modified the paths, and added docstring in each function. Also changed some functions name to be more descriptive |
kevindougherty-noaa
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR addresses the following changes:
Fix Pycodestyle Violation: Corrected a Pycodestyle violation in
/scripts/plot_proftrace.pywithin thedevelopbranch.New Feature Addition: Added a new Python tool,
ObserrorAssignment.py, toush/obsErrorAssignmentTool, facilitating the automated estimation of observation error parameters.fix/cloudy_radiance_info.txt: Needed to read
clw_clr, andclw_cldChanges Included:
obsErrorAssignmentToolDirectory Structure:ObserrorAssignment.py: Python tool for estimating observation error parameters.run_error_model_estimate.sh: Shell script to invoke the Python script.README.md: Provides an overview and usage instructions for the code.Functionality of
ObserrorAssignment.py:error_cld,error_clr,clw_clr, andclw_cld) and creates plots and CSV files for each channel.Example of output plot and CSV file: